Skip to content

Add typing_extensions as core dependency and add install from conda GHA test#202

Merged
valeriupredoi merged 6 commits into
mainfrom
add_core_dep_and_conda_GHA
Feb 25, 2026
Merged

Add typing_extensions as core dependency and add install from conda GHA test#202
valeriupredoi merged 6 commits into
mainfrom
add_core_dep_and_conda_GHA

Conversation

@valeriupredoi

@valeriupredoi valeriupredoi commented Feb 25, 2026

Copy link
Copy Markdown
Collaborator

Description

W have to add typing_extensions as a core dependency since otherwise the package fails to import correctly, I have just rebuilt the conda package with that in mind at conda-forge/pyfive-feedstock#25 and PyPI package will be updated from the next release onwards, after this gets merged. I also added a conda install GHA test.

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@codecov

codecov Bot commented Feb 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.62%. Comparing base (026e388) to head (11aa5eb).
⚠️ Report is 73 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   77.62%   77.62%           
=======================================
  Files          15       15           
  Lines        3128     3128           
  Branches      499      499           
=======================================
  Hits         2428     2428           
  Misses        573      573           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/install-from-conda.yml Outdated
@valeriupredoi
valeriupredoi merged commit 4e549b5 into main Feb 25, 2026
8 checks passed
@valeriupredoi
valeriupredoi deleted the add_core_dep_and_conda_GHA branch February 25, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant