Move footer to Strapi

[A-Wheeto]

Status

• Current Status: Ready for (front-end / tech) review
• Closes https://github.com/NCCE/teachcomputing.org-issues/issues/3039

Review progress:

• Browser tested
• Front-end review completed
• Tech review completed

What's changed?

• Replaced existing footer with CMS Footer component

Steps to perform after deploying to production

If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.

[markjs]

A couple of comments on some of the lookups in the component, otherwise looks good 👍

[markjs]

Seems a bit risky fetching these values based on their order. It looks like there's a key being used elsewhere, perhaps this could be refactored to make use of the key here too instead of first/second?

[markjs]

This method seems a little unnecessary. The company_url and funding_url methods could be rewritten to be more similar to the company_logo and funding_logo methods to just have the data_models_by_type call directly in them and this extracted method wouldn't be needed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[markjs]

@A-Wheeto I don't love the way the view now has a bunch of get_model calls. Especially don't love that some of them then have .render or .value on the end. Feels like the view is now a bit of a mess and the interface to the component values isn't obvious.

How about using the get_model method internally from within the component class but keeping the individual data pieces as methods. So the component would have something like

def company_logo_link
  get_model(:company_logo_link).value
end

def company_logo
  render get_model(:company_logo).render
end

and then your view file can just call each of these methods in place and look nice and tidy.

I'm not sure on having the render call at the start and end of the company_logo method as per my example, still may need to have render company_logo in the view itself but you can try out and see what works.

What do you think?

[A-Wheeto]

Thanks @markjs - on second look you have a good point on the get_model calls in the view. I'll tidy this up.