[pull] trunk from SeleniumHQ:trunk #600
Merged
+18
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix flaky test: use the new port after re-creating test environment 1. When a previous test env was non-"secure", 2. And the current test env is "secure", 3. Then "appServer" was still referring the previous non-secure env. So the test failed with WebDriverException "Reached error page: about:neterror?e=dnsNotFound&u=https%3A//not_a_valid_url.test/&c=UTF-8&d=We%20can%E2%80%99t%20connect%20to%20the%20server%20at%20not_a_valid_url.test" I wonder how it worked at all... * close the unclosed browser in BiDiSessionCleanUpTest BiDiSessionCleanUpTest left the browser open if the test failed. * don't try to stop already stopped server Otherwise, method `NettyServer.stop` failed with NPE because `this.channel` was null.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )