FPM272 - Remove time zone requirement from time-stream #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonstanley
requested changes
Jul 3, 2025
simonstanley
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with Simon and Ollie, we have decided to remove the strict requirement for a time zone to be added to a
TimeSeriesobject. This was causing more problems than it was solving; for example, having to creating time zone aware datetimes for date comparisons with the DataFrame. Ultimately, setting a time zone didn't provide any additional benefits, and we know that all data for FDRI and associated networks e.g. COSMOS will always be UTC anyway.Went for the nuclear option of removing the
time_zoneparameter completely. I did start to implement a strategy of setting aNonevalue as default, but there started to be edge cases I could think of that required interrogating whether the datetimes in the Polars DataFrame were time zone aware - and ultimately decided this was not worth the effort when thetime_zoneattribute wasn't being used for anything anyway.There are downstream updates required for repositories using time-stream: