This repository was archived by the owner on Jun 5, 2019. It is now read-only.
Add SpiDevinceInfo native layer support with reference STM32F4 implementation #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added SpiBusInfo Man/Max Frequency properties as internal calls to pass on to the HAL/PAL to provide hardware specific values. - Implemented New CPU_SPI_xxx APIs for STM32F4. Currently hardcoded to standard values as there's not a lot of value in anything more sophisticated. - removed redundant code used to eliminate warnings in favor of #pragma as code is a storage and perf overhead not worth the price to silence a bening warning.
| @@ -2,15 +2,26 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| #include "windows_devices.h" | |||
| #include "Windows_Devices.h" | |||
There was a problem hiding this comment.
Original casing matches what's in the file system. This should be reverted.
There was a problem hiding this comment.
hmm... Why did we change that from what's generated?
There was a problem hiding this comment.
This isn't a generated file. Casing matches other core libraries.
|
👍 |
smaillet-ms
added a commit
that referenced
this pull request
Jun 17, 2015
Add SpiDevinceInfo native layer support with reference STM32F4 implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #143