This repository was archived by the owner on Jun 5, 2019. It is now read-only.
Refactored conditional compilation for PLATFORM_WINDOWS and WIN32 #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DOWS_EMULATOR as first step in reefactoring to allow cleaner builds and enable x86 based targets that aren't WIN32 based.
… PLATFORM_WINDOWS_EMULATOR split
- moved tableIndex typedefs after the tableKindEnum so they make a bit more sense in context - Added typedefs for the rest of the table index types - Added index type argument to DECLARE_TABLEKIND macro and table_kind<> template to enable generation of greater type safety with templated types and methods. - Added Final to POD structures and other types to enforce intent as sealed classes
…TINYCLR_TRACE_MEMORY_STATS) that was accidentally stripped in conversion to standard _WIN32 checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards splitting the (PLATFORM_WINDOWS==WIN32==x86==Emulator or desktop tools) assumptions in the CLR to allow building for x86 or Win32. This helps enable x86 builds on non-windows platforms, including potentially VMs for testing.
This also updates the DisAsmPE code to clean up some minor things and add some more comments.