Skip to content
This repository was archived by the owner on Jun 5, 2019. It is now read-only.

Fixes issues with endian macros (in GCC) #483

Closed
wants to merge 8 commits into from
Closed

Fixes issues with endian macros (in GCC) #483

wants to merge 8 commits into from

Conversation

josesimoes
Copy link
Contributor

Fixes #481

@smaillet-ms
Copy link
Member

Pease squash those merges out so it makes for a clean merge to main. Other than that I'm 👍 on this.

@josesimoes
Copy link
Contributor Author

I have those two first two commits hanging on my fork for quite some time.
I don't know who to remove those. Tried several approaches without any luck.
Apologies but my GitHub knowledge is very limited...

@smaillet-ms
Copy link
Member

smaillet-ms commented Aug 3, 2016 •
edited
Loading

use: git rebase -i this will pop up your text editor with a list of the changes and some instructions. You can use the word 'squash' to squash those merges so they are effectively ignored as an independent commit that can be rolled back. This helps keep the history on the main branch cleaner as a pull request should be focused on doing one thing so it can be rolled back as a complete unit if needed.

@josesimoes
merge upstream/dev
9f55c2d
@josesimoes
# This is a combination of 8 commits.
82491f6 
# The first commit's message is:
Replace BIG_ENDIAN with NETMF_TARGET_BIG_ENDIAN and LITTLE_ENDIAN with NETMF_TARGET_LITTLE_ENDIAN

Fixes NETMF#481

# This is the 2nd commit message:

Added CMSIS version check (require 4.3.0)

# This is the 3rd commit message:

Update CMSIS 4.3.0 (it now includes RTX)

# This is the 4th commit message:

Cleaned up obsolete CMSIS include paths

# This is the 5th commit message:

- removed ITM Virtual port support from STM32F4 USART driver code

# This is the 6th commit message:

Added support for solution level extensibility for communication transports via generic transport interfaces
- Added new GENERIC_TRANSPORT
- Added new case to all COM redirector APIs to support GENERIC_TRANSPORT handles redirecting to GenericPort_xxx APIS
- Added new GenericPort_xxx APIS to lookup an interface in a table based on the port number and then call through the interface 's function pointer. This allows extensibility without requiring the definition of new transport types.
- added Common CortexMx ITM trace port channel 0 Generic port implementation
- Added support for using ITM0 Generic port to MCBSTM32F400

# This is the 7th commit message:

- modified DEBUG_TRACEXX to use debug_printf instead of hal_printf
- enabled CPU_InitializeCommunication() for all build configurations so debug and trace messages are available even in boot loaders.

# This is the 8th commit message:

- added missing cmsis_generic.h header for generic CMSIS library code use.
@josesimoes
# This is a combination of 42 commits.
8a75b2a 
# The first commit's message is:
Replace BIG_ENDIAN with NETMF_TARGET_BIG_ENDIAN and LITTLE_ENDIAN with NETMF_TARGET_LITTLE_ENDIAN

Fixes NETMF#481

# This is the 2nd commit message:

Removed not broken-out GPIO ports (used only A - E)

PH0 and PH1 deliberately omitted to keep the range continuous.

# This is the 3rd commit message:

restored LWIP cc.h to use debug_printf as that is already set to extern "C" linkage. Changing hal_printf and everything that uses it to ensure it is always extern "C" as well was more work than seems worth it in this case.

# This is the 4th commit message:

Change DateTime.UtcNow.Kind from Local to Utc.

# This is the 5th commit message:

STM32F4DISCOVERY: TinyBooter uses ITM0

USART driver and PAL replaced with stubs.

# This is the 6th commit message:

Replaced 'tinyclr' with $(AssemblyName) in STM32F4DISCOVERY TinyCLR.proj

Synced with MCBSTM32F400, commit 78f5cb3.

# This is the 7th commit message:

- fixed assemblyinfo for Microsoft.VisualBasic.dll

# This is the 8th commit message:

-removed VS express SKU support as it causes issues with publishing to VS gallery and we don't need it anymore now that the VS community edition is freely available.
- fixed VS14 integration solution and projects to allow build and debug with VS experimental Hive

- added missing buildTasks project to depenencies for VS integration solution
- added missing WinUsb project reference for VS integration

Resolved circular dependency on build task projects
- removed project references to build task projects as they are needed to build other projects
- Create standalone solution to build the build task projects needed by other projects to allow building them independently of everything else. (NOTE: that msbuild.exe will normally leave an instance of itself running with all previously loaded tasks still loaded. Thus to build the build tasks it may be required to kill the pending msbuild.exe instance(s) to release the DLLs [It will timeout on it's own after a few minutes as well])

- Added standard project configuration settings to project files
- works ok in VS but busted on command line builds (the non standard nature of the current projects makes a mess of this - they need to be brought into standard project form)

restored direct <Reference> tags for assemblies since the command line build from Build_sdk won't process ProjectReferences properly (Fixing that is a complete re-write of the build)
- Added some dependency logging to the Common targets file to log child projects to help in tracking dependency issues.
- updated VSIX manifest to official RTM name of Visual Studio 2015

- Fixed solution configuration settings so it doesn't mix debug and release settings on a single solution configuration.
- Fixed WinUsb and Debugger CSPROJ files to set OutDir to the proper build output location

# This is the 9th commit message:

Fixed ConvertCOM_ComHandle() parameters (start from zero)

# This is the 10th commit message:

Revert "Fix DateTime Ticks to match the behavior of .NET"

This reverts commit 79a595a.

# This is the 11th commit message:

- updated cmsis_os_cpp.h to latest RTX data structure layout
- updated C++ support macros for timeres and mutex to maintain consistency between them for use. (e.g. 3 seperate macros, one to declare a member of a class, one for the constructor initializaion list and a third to be used in the constructor to perform final init/construction. This pattern ensures that the correct action is taken and allows for greater version implementation detal isolation. It is possible that the internals of the macro can change or even be empty in some cases and then in a new version change.
- forced all RAM regions propr to the LWIP init region to uncompressed, this is to work around the linker bug in the ARMCC tool chain. WHile that bug was fixed in the latest toolchain, not everyone has upgraded. In the next release of NETMF we'll reset the min requiremeents to include the fix - until then we'll keep the workaround.

# This is the 12th commit message:

Fix UTF8 to UTF16 conversion for special characters

# This is the 13th commit message:

- adding in support for legacy crypto, which was removed previously. Turns out it is still needed by TinyBooter/mfdeploy for firmware signature checks as a small footprint crypto lib.

- added default keys for signing. Users should create their own keys for security but providing a key prevents errors from hitting the build until they get to understanding that phase of things.

# This is the 14th commit message:

Update README.md
# This is the 15th commit message:

Revert "Restored Legacy Crypto support"

# This is the 16th commit message:

- Added code to tinybooter to dump out newkey, signature and current key on failure to verify signature on key updates to aid in diagnosing issues with Crypto library.
- fixed multiple issues of return or throw on smae line as conditional expression which make debugging difficult. (Some debuggers can't set breakpoints on line and column)
- for the crypto.lib project forced mapping MDK to the RVDS3.1 thumb2 crypto libraries.
- added more readable wire-protocal packet tracing, now prints the command id as a textual name along with a decoded form of the flags with textual names for all active flags to aid in debugging the communications.
- fixed DLLImports for the Crypto.dll to use CDecl calling convention to prevent issues with stack corruption and eliminate MDA exception while debugging.

- Fixed flash driver for MCBSTM32F400 to check for ready status after erase to ensure chip is in a valid state before continuing. Othereise the chip can get corrupted (particularly the Config sector)

- Added Addditional debug and ETW tracing for the NETMF wireprotocol in MFDeploy and VS integration.
- Added additional trace messaging support toe device side wire protocol to help in tracking any failures that might occur on a device.

- Fixed tracing to eprovide event code on WireProtocolTxHeader.

# This is the 17th commit message:

Revert "Adding support to provide more useful and actionalble diagnostics for Crypto libs and wire protocol debugging"

# This is the 18th commit message:

Updated string table inputs in Microsoft.SPOT.Support.Settings

# This is the 19th commit message:

StringTable data moved into separate file StringTableData.cpp (to avoid manual edits)

Now the data file can be replaced directly with the generated one.

# This is the 20th commit message:

Excluded generated strings from StringTable

$$method0x...
<PrivateImplementationDetails>{...guid}
__StaticArrayInitTypeSize=...

# This is the 21st commit message:

Updated string table data - generated from Microsoft.SPOT.Native.strings and mscorlib.strings

# This is the 22nd commit message:

Deleted unused InitString() functions

TINYCLR_CREATE_STRINGTABLE symbol is not used anymore, never defined.

# This is the 23rd commit message:

Added string table inputs information to StringTableData.cpp

Inline task PrependLinesToFile created to workaround ReadLinesFromFile limitations.

# This is the 24th commit message:

Deleted unused compile_stringtable.cmd script

The StringTable is now generated via 'buildstring' target in
Tools\Targets\Microsoft.SPOT.Support.Settings

# This is the 25th commit message:

Update the Interface tests to reflect the known issue related to NETMF#95

# This is the 26th commit message:

Fix TimerServiceTests

# This is the 27th commit message:

Fix http test for checking microsoft server

# This is the 28th commit message:

Eliminated VS14 build_sdk compiler warning C4474: 'wprintf' : too many arguments passed for format string

# This is the 29th commit message:

Eliminated VS14 build_sdk compiler warning C4477: 'wprintf' : format string '%f' requires an argument of type 'double', but variadic argument 1 has type 'CLR_INT32'

# This is the 30th commit message:

Eliminated VS14 build_sdk compiler warning C4477: 'wprintf' : format string '%g' requires an argument of type 'double', but variadic argument 1 has type 'CLR_INT64'

# This is the 31st commit message:

Set error on LINGER and DONTLINGER socket options

# This is the 32nd commit message:

GroupTests encoding is ASCII.
Changed to Unicode for TM special character

# This is the 33rd commit message:

STM32F4x9_Flash_driver.cpp also needs FLASH definition

# This is the 34th commit message:

Revert "STM32F4x9_Flash_driver.cpp also needs FLASH definition"

# This is the 35th commit message:

Fix the condition for setting static DNS

# This is the 36th commit message:

Fix NetInfo Tests

# This is the 37th commit message:

Fix http tests issues

# This is the 38th commit message:

- Added git ignore for the binary only crypto libraries so they don't get added into the tree
- Updated codesign certificate ids to current Microsoft SHA2 variants.

# This is the 39th commit message:

- adding in support for legacy crypto, which was removed previously. Turns out it is still needed by TinyBooter/mfdeploy for firmware signature checks as a small footprint crypto lib.

- added default keys for signing. Users should create their own keys for security but providing a key prevents errors from hitting the build until they get to understanding that phase of things.

# This is the 40th commit message:

- Added code to tinybooter to dump out newkey, signature and current key on failure to verify signature on key updates to aid in diagnosing issues with Crypto library.
- fixed multiple issues of return or throw on smae line as conditional expression which make debugging difficult. (Some debuggers can't set breakpoints on line and column)
- for the crypto.lib project forced mapping MDK to the RVDS3.1 thumb2 crypto libraries.
- added more readable wire-protocal packet tracing, now prints the command id as a textual name along with a decoded form of the flags with textual names for all active flags to aid in debugging the communications.
- fixed DLLImports for the Crypto.dll to use CDecl calling convention to prevent issues with stack corruption and eliminate MDA exception while debugging.

- Fixed flash driver for MCBSTM32F400 to check for ready status after erase to ensure chip is in a valid state before continuing. Othereise the chip can get corrupted (particularly the Config sector)

- Added Addditional debug and ETW tracing for the NETMF wireprotocol in MFDeploy and VS integration.
- Added additional trace messaging support toe device side wire protocol to help in tracking any failures that might occur on a device.

- Fixed tracing to eprovide event code on WireProtocolTxHeader.

Conflicts:
	crypto/dotNetMF.proj

# This is the 41st commit message:

Enabling time service for MCBStM32F400

# This is the 42nd commit message:

- Enabled debug symbol information for release and RTM builds with MDK toolchain (It doesn't impact optimizations but allows for actual source debugging of release builds via JTAG debugger)
@josesimoes
# This is a combination of 20 commits.
07b3cf3 
# The first commit's message is:
Replace BIG_ENDIAN with NETMF_TARGET_BIG_ENDIAN and LITTLE_ENDIAN with NETMF_TARGET_LITTLE_ENDIAN

Fixes NETMF#481

# This is the 2nd commit message:

-Removed WSAEWOULDBLOCK as it's existence causes conditional checks to generate incorrect code for NETMF devices. (basically if WASEWOULDBLOCK exists AND is the same as EWOULDBLOCK on a non-windows targeted build, then EWOULDBLOCK gets treated as a fatal error instead of a bening notification)

# This is the 3rd commit message:

- updated signing approvers
- updated reference to code signing object for latest object as installed on build server

# This is the 4th commit message:

update build signe to be a bit more soft on errors from service when waiting

# This is the 5th commit message:

Update README.md
# This is the 6th commit message:

Added additional hint path for code sign submitter so that external builds can succeed (even though signing isn't performed externally the component is needed to complete building the msbuild task dll)

# This is the 7th commit message:

Cleanup: Deleted unused <CustomSpecific> tag from .proj files

In solution projects it contains the solution name,
which is usually changed during the cloning process.

# This is the 8th commit message:

Cleanup: Deleted empty ProjectPath attributes from *proj files

# This is the 9th commit message:

Cleanup: Deleted <ProjectPath> from solution project files

# This is the 10th commit message:

enc28j60 problem fixed
when using with CMSIS RTOS

# This is the 11th commit message:

Fix Emulator hanging when using TLS/SSL

Implement fix suggested in NETMF#330
This is a fix that has been proposed by Xin Chen of the AMQP Lite project.
 See:
http://amqpnetlite.codeplex.com/wikipage?title=NETMF%20and%20TLS%2fSSL%20connection&referringTitle=Documentation
# This is the 12th commit message:

Update README.md
# This is the 13th commit message:

Improve code layout

Improve code layout for readability as requested by @smaillet-ms

# This is the 14th commit message:

fixed compile error through adding FLASH macro

# This is the 15th commit message:

Remove warning in graphics.cpp

# This is the 16th commit message:

Removed application signing

# This is the 17th commit message:

update gitignore to include readme and licenses from Crypto package

# This is the 18th commit message:

declare buffer with RSA_BLOCK_SIZE_BYTES

# This is the 19th commit message:

Add quotes to buildhelper paths to cope with embedded spaces and other special characters in the path

# This is the 20th commit message:

Set FLAVOR_WIN to match FLAVOR_DAT if it is not defined
@josesimoes
# This is a combination of 2 commits.
3df5866 
# The first commit's message is:

Replace BIG_ENDIAN with NETMF_TARGET_BIG_ENDIAN and LITTLE_ENDIAN with NETMF_TARGET_LITTLE_ENDIAN

Fixes NETMF#481

# This is the 2nd commit message:

- Refactored headers and code to allow SDK to build using new _WIN32, PLATFORM_WINDOWS_EMULATOR split
@josesimoes
Replace BIG_ENDIAN with NETMF_TARGET_BIG_ENDIAN and LITTLE_ENDIAN wit…
bc76fbb 
…h NETMF_TARGET_LITTLE_ENDIAN

Fixes NETMF#481
@josesimoes
Merge branch 'fix-big-endian' of https://github.com/Eclo/netmf-interp…
0263f53 
…reter.git
@josesimoes
Copy link
Contributor Author

Before I totally loose my sanity with the GitHub command line, I'm closing this PR and will submit a new one. Hopefully meeting the requirements...

@josesimoes josesimoes closed this Aug 4, 2016
@josesimoes josesimoes deleted the fix-big-endian branch August 4, 2016 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @smaillet-ms