This repository was archived by the owner on Jun 5, 2019. It is now read-only.
TinyBooter explicitly uses crypto stubs #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a few issues with the legacy crypto libraries that popped out in @josesimoes PR #475 (also related to #341).
Explicitly referencing crypto_stub.lib ensures that crypto\dotnetmf.proj does not automagically select either crypto.lib or crypto_stub.lib based solely on the presence of lib...\crypto.lib, which requires a manual installation; and also so it does not force GCC to use binaries built with ARM/Keil which results in linker warnings (VFP mismatch) or errors (when using newlib-nano).
(It also makes TinyBooter considerably smaller, just under 32 KB, for both MDK and GCC 5.3+ builds).
In case there is any solution based on these two DISCO implementations that require crypto functionality, I would recommend to fix the build steps in crypto\dotnetmf.proj (and provide proper binary for GCC; I guess none of which will happen due to the plan to completely abandon this).