Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds code coverage tooling and refactors the get_recommendations() method to resolve publication IDs without requiring posts. The main changes include adding pytest-cov as a development dependency and implementing a new _resolve_publication_id() method that queries Substack's discovery API directly.
- Added
pytest-covfor test coverage measurement - Refactored
get_recommendations()to use discovery API search instead of fetching posts - Added comprehensive test coverage for the new resolution logic and edge cases
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added pytest-cov>=7.0.0 to dev dependencies |
| uv.lock | Updated lock file with coverage and pytest-cov packages |
| .gitignore | Added coverage-related files to gitignore |
| substack_api/newsletter.py | Implemented publication ID resolution via discovery API with helper functions |
| tests/test_newsletter.py | Added extensive test coverage for new functionality and edge cases |
Comments suppressed due to low confidence (1)
substack_api/newsletter.py:273
- The module 'substack_api.newsletter' imports itself.
from .newsletter import Newsletter # avoid circular import
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses search endpoint to grab newsletter ID, rather than pulling most recent post (prone to 404s)