Skip to content

Fix domain name parser #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
k0ekk0ek opened this issue Aug 4, 2023 · 1 comment
Closed

Fix domain name parser #93

k0ekk0ek opened this issue Aug 4, 2023 · 1 comment

Comments

@k0ekk0ek
Copy link
Contributor

k0ekk0ek commented Aug 4, 2023

A mere . (dot), or <root> is not handled correctly yet for quoted domain names. A quick fix was put in place because the algorithm must be updated anyway. i.e. delimited_t was put in place to quickly cover parsing of RRTYPE as part of #64, but after #81 that's no longer required. The delimiter check can even be improved upon and a better algorithm may even be put in place as part of #66.

@k0ekk0ek
Copy link
Contributor Author

Since the length member was re-introduced for tokens in #96, contiguous and non-quoted domain names are parsed using the same logic and the updated name parser explicitly checks for . (root label). This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant