Skip to content

Fix bad URL in /browse/All#1605

Merged
DariusIII merged 1 commit intoNNTmux:masterfrom
Kcchouette:patch-1
Sep 2, 2024
Merged

Fix bad URL in /browse/All#1605
DariusIII merged 1 commit intoNNTmux:masterfrom
Kcchouette:patch-1

Conversation

@Kcchouette
Copy link
Copy Markdown
Contributor

I fix the case of

  • going to /browse/All
  • value of URL is browse//All%7D

Be careful that in this case, we seeHome / / All

The double // is because in case of the All there is no $parentcat

If we really change && $catname != 'all' to && $catname != 'All', we would see Home / /
So I didn't fix that

@Kcchouette Kcchouette changed the title Update browse.tpl Fix bad URL in /browse/All Sep 2, 2024
@DariusIII
Copy link
Copy Markdown
Member

I tried your fix and i see no difference in URL display with existing code, and the spacing after "Home" is needless as it was without space intentionally.

Am i missing something here?

@Kcchouette
Copy link
Copy Markdown
Contributor Author

It only fixes the url (when you click on "All" word)

Do not forget to delete temp smarty cache https://github.com/NNTmux/newznab-tmux/wiki/Dev-notes#working-on-tpl-files 😬

@DariusIII
Copy link
Copy Markdown
Member

It only fixes the url (when you click on "All" word)

Do not forget to delete temp smarty cache https://github.com/NNTmux/newznab-tmux/wiki/Dev-notes#working-on-tpl-files 😬

You do realize there are commands for this?

php artisan ytake:smarty-clear-compiled

php artisan ytake:smarty-clear-cache

Btw, i still have the same error with your fix :(

@Kcchouette
Copy link
Copy Markdown
Contributor Author

Btw, i still have the same error with your fix :(

I've not idea why :( it fixes correctly on my side

@DariusIII DariusIII merged commit 6689e91 into NNTmux:master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants