Skip to content

refactor: use backslash on windows - #384

Open
NSPC911 wants to merge 1 commit into
masterfrom
use-backslash
Open

NSPC911 wants to merge 1 commit into
masterfrom
use-backslash

Conversation

@NSPC911

@NSPC911 NSPC911 commented Nov 17, 2026

Copy link
Copy Markdown
Owner

problem originally faced is that i set every path to use / in windows, which is a problem since for example, wsl needs to connect to \\wsl$ instead of //wsl$.

This pr changes every instance of a forced / to use the os's appropriate separator


by submitting this pull request, i agree that

  • i have run poe check to check for any style issues and fixed them
  • i have tested rovr (and also ran poe test if applicable) to make sure my changes do not break anything
  • cache, logs, dotfiles and/or others were not accidentally added to git's tracking history
  • my commits (or at least the pr title) follow the conventional commits format as much as possible
  • i did not use an AI (or LLM) in any way to write code.

holy thats a lot of stuff
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 634993d9-dff9-41b8-ad93-c4eab3be1b26
Commits

Reviewing files that changed from the base of the PR and between 1e5492c and 965f792.

Files selected for processing: 31

  • docs/src/content/docs/dev/reference/schema.mdx
  • src/rovr/__main__.py
  • src/rovr/action_buttons/new_item_button.py
  • src/rovr/assets/schema.json
  • src/rovr/classes/config.pyi
  • src/rovr/classes/textual_validators.py
  • src/rovr/core/file_list.py
  • src/rovr/first_launch.py
  • src/rovr/footer/clipboard_container.py
  • src/rovr/footer/process_container.py
  • src/rovr/functions/cache.py
  • src/rovr/functions/cli.py
  • src/rovr/functions/config.py
  • src/rovr/functions/drive_workers.py
  • src/rovr/functions/folder_prefs.py
  • src/rovr/functions/path.py
  • src/rovr/header/tabs.py
  • src/rovr/navigation_widgets/path_input.py
  • src/rovr/screens/archive_creator.py
  • src/rovr/screens/input.py
  • src/rovr/screens/trash.py
  • src/rovr/variables/maps.py
  • tests/test_chooser.py
  • tests/test_clipboard.py
  • tests/test_drive_workers.py
  • tests/test_folder_prefs.py
  • tests/test_functions_path.py
  • tests/test_functions_pins.py
  • tests/test_navigation.py
  • tests/test_path_input.py
  • tests/test_state_manager.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@NSPC911

NSPC911 commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 54 minutes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant