feat: Sanitize logging for image modality#697
Merged
Conversation
agronskiy
approved these changes
Feb 4, 2026
| and isinstance(value, str) | ||
| and value.startswith("data:image/") | ||
| ): | ||
| match = re.match(r"data:image/([^;]+);base64,(.+)", value) |
Collaborator
There was a problem hiding this comment.
Cann image (the capturing group) be empty?
Contributor
Author
There was a problem hiding this comment.
[^;]+ denotes one or more characters, so it cannot be empty.
Not that I know this, Cursor told me 😆
Signed-off-by: Wojciech Prazuch <[email protected]>
9635e01 to
3f572a8
Compare
Contributor
Author
|
/ok to test 3f572a8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running MMMU Pro, the logging from Caching Interceptor congests the stdout with base64 encoded strings of characters. This makes logging, and progress following of image-based harnesses impossible to investigate and track.
After this fix, the stdout is now clear and readable:
Note the
{'type': 'image_url', 'image_url': {'url': '<image: format=png, size≈385128 bytes>'}},sanitized description of the input.