Repository navigation
fix(aviary_agent): add type discriminators to the mocked /verify response - #2461
Merged
ananthsub merged 1 commit intoAug 10, 2026
Merged
Conversation
…onse `NeMoGymResponseOutputItem` gained a `BeforeValidator` in NVIDIA-NeMo#2438 that rejects dicts without a `type` field. `test_run_workflow` mocks the /verify echo with an untagged item, `{"role": "user", "content": "obs"}`, so validating that payload into `AviaryAgentVerifyResponse` now raises. The validator is right to reject it. Without the guard, an untagged output-call dict validates as the wrong union member: a web-search call with no `type` becomes `NeMoGymResponseMcpListTools`. Real transitions are unaffected. `AviaryAgent.run` posts `verify_request.model_dump()`, and `AviaryResourcesServer.verify` echoes that back, so each item carries its `type`. The mocked transition now matches what the agent builds in this scenario: the seeded observation, the tool call, and the tool output. The test asserts the item types after validation. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
cmunley1
approved these changes
Aug 10, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NeMoGymResponseOutputItemgained aBeforeValidatorin #2438 that rejects dicts without atypefield.test_run_workflowmocks the /verify echo with an untagged item,{"role": "user", "content": "obs"}, so validating that payload intoAviaryAgentVerifyResponsenow raises.Without the guard, an untagged output-call dict validates as the wrong union member: a web-search call with no
typebecomesNeMoGymResponseMcpListTools.The Aviary integration is unaffected.
AviaryAgent.runpostsverify_request.model_dump(), andAviaryResourcesServer.verifyechoes that back, so each item carries itstype.