Skip to content

[Super 3.5 evals] Terminus2 Model call timeout parity; Servers cancel requests when client cancels requests - #3064

Merged
bxyu-nvidia merged 2 commits into
mainfrom
bxyu/super-3.5-evals-20260903
Sep 3, 2026
Merged

bxyu-nvidia merged 2 commits into
mainfrom
bxyu/super-3.5-evals-20260903

Conversation

@bxyu-nvidia

@bxyu-nvidia bxyu-nvidia commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

  1. Servers cancel requests when client cancels requests: nemo_gym/mcp_auto_exposure.py, nemo_gym/server_utils.py, tests/unit_tests/test_server_utils.py
  2. Terminus2 Model call timeout parity: resources_servers/terminal_bench_2_1/app.py, responses_api_agents/terminus_2_sandboxed_agent/tests/test_app.py, responses_api_agents/terminus_2_sandboxed_agent/app.py

Checklist

  • I have read the contributing guidelines.
  • The change is focused; unrelated "drive-by" edits are tracked as separate issues/PRs.
  • Tests added or updated and pass locally, or N/A for docs-only / non-code changes (so CI unit/server checks pass when applicable).
  • Pre-commit checks pass locally (pre-commit run --all-files) (so CI lint/format/copyright pass).
  • All commits have DCO sign-off (git commit -s) (so the DCO check passes).

Signed-off-by: Brian Yu <bxyu@nvidia.com>
ffrujeri
ffrujeri previously approved these changes Sep 3, 2026
Signed-off-by: Brian Yu <bxyu@nvidia.com>
@bxyu-nvidia
bxyu-nvidia merged commit 73d292c into main Sep 3, 2026
38 checks passed
@bxyu-nvidia
bxyu-nvidia deleted the bxyu/super-3.5-evals-20260903 branch September 3, 2026 20:49
jkyi-nvidia pushed a commit that referenced this pull request Sep 11, 2026
… requests when client cancels requests (#3064)

<!-- Thanks for contributing to NeMo Gym! Please fill out the sections
below. -->

## What does this PR do?

1. Servers cancel requests when client cancels requests:
nemo_gym/mcp_auto_exposure.py, nemo_gym/server_utils.py,
tests/unit_tests/test_server_utils.py
2. Terminus2 Model call timeout parity:
resources_servers/terminal_bench_2_1/app.py,
responses_api_agents/terminus_2_sandboxed_agent/tests/test_app.py,
responses_api_agents/terminus_2_sandboxed_agent/app.py

## Checklist

- [ ] I have read the [contributing
guidelines](https://docs.nvidia.com/nemo/gym/latest/contribute/development-setup).
- [ ] The change is focused; unrelated "drive-by" edits are tracked as
separate issues/PRs.
- [ ] Tests added or updated and pass locally, or N/A for docs-only /
non-code changes (so CI unit/server checks pass when applicable).
- [ ] Pre-commit checks pass locally (`pre-commit run --all-files`) (so
CI lint/format/copyright pass).
- [ ] All commits have DCO sign-off (`git commit -s`) (so the DCO check
passes).

---------

Signed-off-by: Brian Yu <bxyu@nvidia.com>
Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
katherineh123 pushed a commit to katherineh123/Gym that referenced this pull request Oct 2, 2026
…IDIA-NeMo#3931)

## What does this PR do?

Stops the OpenCode agent's sandbox when a rollout is cancelled or fails,
not only when it succeeds.

Since NVIDIA-NeMo#3064, a Gym server cancels the request handler when its caller
disconnects. That stops the work inside the handler, but OpenCode runs
as a separate process inside the sandbox. It keeps working, and keeps
calling the model, until the sandbox is stopped. `run()` only stopped
the sandbox after a successful `/verify`, so a cancelled rollout left
its pod running until the sandbox TTL (`ttl_s: 18000`, 5 h, in the
shipped configs).

Signed-off-by: gwarmstrong <gwarmstrong@users.noreply.github.com>
Signed-off-by: George Armstrong <georgea@nvidia.com>
Co-authored-by: gwarmstrong <gwarmstrong@users.noreply.github.com>

This branch was previously deployed

1 inactive deployment
public — 4fb93c3a Deployed Sep 3, 2026 by copy-pr-bot[bot] via release / finalize / notify #2514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants