Repository navigation
[Super 3.5 evals] Terminus2 Model call timeout parity; Servers cancel requests when client cancels requests - #3064
Merged
Merged
Conversation
ffrujeri
reviewed
Sep 3, 2026
ffrujeri
reviewed
Sep 3, 2026
ffrujeri
previously approved these changes
Sep 3, 2026
This was referenced Sep 8, 2026
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
… requests when client cancels requests (#3064) <!-- Thanks for contributing to NeMo Gym! Please fill out the sections below. --> ## What does this PR do? 1. Servers cancel requests when client cancels requests: nemo_gym/mcp_auto_exposure.py, nemo_gym/server_utils.py, tests/unit_tests/test_server_utils.py 2. Terminus2 Model call timeout parity: resources_servers/terminal_bench_2_1/app.py, responses_api_agents/terminus_2_sandboxed_agent/tests/test_app.py, responses_api_agents/terminus_2_sandboxed_agent/app.py ## Checklist - [ ] I have read the [contributing guidelines](https://docs.nvidia.com/nemo/gym/latest/contribute/development-setup). - [ ] The change is focused; unrelated "drive-by" edits are tracked as separate issues/PRs. - [ ] Tests added or updated and pass locally, or N/A for docs-only / non-code changes (so CI unit/server checks pass when applicable). - [ ] Pre-commit checks pass locally (`pre-commit run --all-files`) (so CI lint/format/copyright pass). - [ ] All commits have DCO sign-off (`git commit -s`) (so the DCO check passes). --------- Signed-off-by: Brian Yu <bxyu@nvidia.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
katherineh123
pushed a commit
to katherineh123/Gym
that referenced
this pull request
Oct 2, 2026
…IDIA-NeMo#3931) ## What does this PR do? Stops the OpenCode agent's sandbox when a rollout is cancelled or fails, not only when it succeeds. Since NVIDIA-NeMo#3064, a Gym server cancels the request handler when its caller disconnects. That stops the work inside the handler, but OpenCode runs as a separate process inside the sandbox. It keeps working, and keeps calling the model, until the sandbox is stopped. `run()` only stopped the sandbox after a successful `/verify`, so a cancelled rollout left its pod running until the sandbox TTL (`ttl_s: 18000`, 5 h, in the shipped configs). Signed-off-by: gwarmstrong <gwarmstrong@users.noreply.github.com> Signed-off-by: George Armstrong <georgea@nvidia.com> Co-authored-by: gwarmstrong <gwarmstrong@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
pre-commit run --all-files) (so CI lint/format/copyright pass).git commit -s) (so the DCO check passes).