Repository navigation
feat(sandbox): support Docker pipe process sessions - #3556
cwing-nvidia wants to merge 3 commits into
Conversation
Signed-off-by: Chris Wing <cwing@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Chris Wing <cwing@nvidia.com>
|
/claude review |
|
SHIP — clean, well-tested addition of pipe-mode process sessions to the Docker provider. No correctness or async-hang concerns. Reviewed against the areas that page an on-call engineer:
NOTE (author's call, not blocking): |
Signed-off-by: Chris Wing <cwing@nvidia.com>
|
We’re doing some cleanup of the open PR list. This PR has had no activity for over a month, so I’ve moved it back to draft. If this change is still needed, please resolve any merge conflicts and mark the PR ready for review again when it’s ready to merge. Thanks! |
|
Closing as superseded by #4862, which added |
Summary
docker exec -i.Why
Borrowed-sandbox agents need a long-lived bidirectional process inside a container, while the Docker provider previously exposed only one-shot commands. This adds the provider-neutral process-stream capability those agents require without conflating it with PTY support.
No issue is linked because this is a focused provider capability extracted from the environment-runtime design prototyping work.
Behavior and lifecycle
The implementation uses a startup handshake, process-group signaling, control-file cleanup, cancellation-safe close behavior, and a dedicated concurrency limit for long-lived sessions.
Detached sessions and
pty=trueremain unsupported.Compatibility
This is additive. Existing Docker create, one-shot exec, copy, connect, and close behavior is unchanged. Process sessions remain local to the Docker client and container, consistent with the provider's existing local-daemon scope.
Feedback requested
For borrowed-sandbox agent authors
For sandbox-provider maintainers
Validation
1.0with no episode failure.