Repository navigation
feat(core): expose aiohttp pool wait telemetry #3632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
1e228e7
Expose aiohttp pool wait telemetry
athitten 1a45570
fix(core): attribute pool pressure and harden capacity reporting
athitten b111268
fix(core): record benchmark errors and use the production client
athitten 9b3f3d2
Remove benchmark script
athitten 6c46eae
Merge latest main
athitten db5d90e
Rename pool queue constraint attribute
athitten d7673d7
fix(core): address pool telemetry review
athitten 61269a2
docs(agent): clarify remote retry ownership
athitten bb73579
Merge origin/main into athitten/issue-3008
athitten 9a6605f
perf: reduce connection queue metric overhead
athitten e40867e
fix: avoid misleading descriptor warnings
athitten 16a21a9
fix: label first outbound connection attempt
athitten ab01a21
fix: preserve client initialization tracing
athitten d1af7a6
test: cover pool tracing and destination labels
athitten 2bf2734
test: bound connection pool test cleanup
athitten e62eb24
refactor: clarify metrics exporter state
athitten 0cb5555
fix: identify HTTP metric destinations
athitten 6afdfda
test: verify queued redirect sampling
athitten c569325
docs: clarify sustained connector overshoot
athitten 0d5f727
docs: clarify pool metrics process coverage
athitten 7c255d6
fix: label per-worker pool capacity
athitten 7b0439d
docs: explain pool capacity and destinations
athitten e74b8e8
docs: clarify pool sizing guidance
athitten 10f4317
test: cover pool limit edge cases and startup report
athitten 1b1f171
test: assert remote agent pool destination label
athitten 21f2b12
test: bound pool tests and guard connect override
athitten 3639e88
Apply batched suggestions from code review
athitten de00582
fix(core): address pool telemetry follow-up review
athitten d6b15ff
Merge origin/main into athitten/issue-3008
athitten a8c03d7
fix(core): record pool metrics when reusing lens providers
athitten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configuration.mdx:121Non-blocking: one more sentence here would explain the bursty total-limit waits in the PR's own benchmark table.
connect()tries to reuse an idle pooled connection before it checks any limit or joins the wait queue (connector.py#L627-L634).A new request for a host with an idle socket therefore skips requests that are already waiting.
Waits behind the total limit are not first come, first served, so a few requests can wait much longer than the backend latency.
Please add a sentence saying that total-limit waits are not FIFO, because requests that reuse pooled sockets bypass waiting requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in fern/versions/latest/pages/reference/configuration.mdx:122. Added that pool waits are not first come, first served: a request that can reuse an idle connection skips waiting requests, and aiohttp wakes waiting hosts in random order.