Repository navigation
docs(skills): add-benchmark health checks and session rules - #4627
Merged
Merged
Conversation
This was referenced Oct 16, 2026
gchlebus
approved these changes
Oct 22, 2026
wprazuch
enabled auto-merge
October 23, 2026 06:52
Step 7 is now health checks instead of a model baseline. Adds the mask_sample rule, session-state rules for resources servers and a short route for adding a harness. Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
wprazuch
force-pushed
the
wprazuch/add-benchmark-skill-checks
branch
from
October 23, 2026 06:54
f86d771 to
ef73925
Compare
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/39914491040 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the
add-benchmarkskill (.agents/skills/add-benchmark/SKILL.md).mask_sample,failure_kindandfailure_reason, not a 0.0 reward.num_workers: 1,close_resources_session(), a per-session lock, free on failed seed,VERIFIER_FIXTURE,REVERIFY_MODE).gym eval compare, saved config. It replaces the old Qwen baseline step.Steps 1 to 6 are unchanged.
Validation
pre-commit run --all-filespasses.ReverifyMode,close_resources_session,VERIFIER_FIXTURE,num_workerson agent servers.Rollout evidence
N/A. Docs-only change, no code or config.
No issue: small docs change.