Repository navigation
docs(harbor): deprecate harbor_agent and harbor_agent_general in favour of the Harbor task format - #4826
Merged
Conversation
Contributor
Author
|
/ok to test 139e72b |
Contributor
|
🌿 Preview your docs: https://nvidia-preview-pr-4826-63b1ef6ae59f.docs.buildwithfern.com/nemo/gym |
This was referenced Oct 22, 2026
ffrujeri
previously approved these changes
Oct 26, 2026
Contributor
Author
|
/ok to test 01f61b6 |
adil-a
force-pushed
the
adasif/deprecate-harbor-agents
branch
from
October 26, 2026 22:27
01f61b6 to
6c61d05
Compare
Contributor
Author
|
/ok to test 6c61d05 |
Contributor
Author
|
/ok to test a212902 |
…ur of the Harbor task format Both Harbor bridge agents now say, in their READMEs and in a warning logged at server startup, that they are deprecated and will be removed soon, and that new work should run Harbor tasks through the Harbor environment server (the Harbor task format stack starting at #3674). The ecosystem page carries the same note. One test per agent asserts the startup notice. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Adil Asif <adasif@nvidia.com>
… server and tie removal to the remaining benchmarks The harbor environment server is on main and the Harbor Tasks docs page exists, so the banners, the startup warnings and the ecosystem entry link there instead of the PR stack and a folder that did not exist yet. Removal is gated on the seven benchmarks still running through these agents (biomnibench_da, biomysterybench, bixbench_hypothesis, genebench_pro, labbench2_pdf, legal_agent_bench, openthoughts_tblite) moving to the Harbor task format; the notices say so instead of "removed soon". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Adil Asif <adasif@nvidia.com>
…off moving docs pages Review follow-up on the deprecation notices: - about/ecosystem.mdx and the root README link "Harbor" to environment_servers/harbor, without a deprecation note on the ecosystem page; the deprecated agents' own READMEs carry it. - The startup warnings and README banners of harbor_agent and harbor_agent_general point at the harbor environment server's README instead of the data/harbor-tasks docs page, which #5131 moves. The notices no longer depend on where the Harbor docs pages land. - The deprecation tests assert the repo path and that no docs URL is named. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Adil Asif <adasif@nvidia.com>
Users of the seven built-in benchmarks that still run through harbor_agent or harbor_agent_general did not pick the agent and have nothing to change. The startup warning and the README banners now say those benchmarks will be migrated to the harbor environment server and that no action is needed yet, and keep pointing new work at the environment server. The deprecation tests assert the no-action wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Adil Asif <adasif@nvidia.com>
…rbor_agent_general skillsbench (added 27 Oct) also runs through harbor_agent_general, so the deprecation banners now name all eight built-in benchmarks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Adil Asif <adasif@nvidia.com>
adil-a
force-pushed
the
adasif/deprecate-harbor-agents
branch
from
November 7, 2026 04:51
a212902 to
63b1ef6
Compare
Contributor
Author
|
/ok to test 63b1ef6 |
cwing-nvidia
approved these changes
Nov 9, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/42666224423 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/42668966265 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 9, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/42735213824 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marks
responses_api_agents/harbor_agentandresponses_api_agents/harbor_agent_generalas deprecated. Both are superseded by the Harbor task format, where Harbor tasks run through the Harbor environment server with NeMo Gym's own sandboxed harnesses and theharbor_oracleagent, with no Harbor dependency (PR stack starting at #3674).What changes:
model_post_init) in both agents with the same pointer.No behaviour change otherwise. The
terminal_bench_2_1andterminal_bench_4servers are untouched. No removal date is set yet.Test plan
responses_api_agents/harbor_agent/tests: 84 passed, 6 failed. The same 6 fail identically on a clean export ofmain(Daytona import path and CPU pin environment tests), unrelated to this change.responses_api_agents/harbor_agent_general/tests: 54 passed.pre-commit run --files <changed files>: all hooks pass.🤖 Generated with Claude Code