Skip to content

docs(harbor): deprecate harbor_agent and harbor_agent_general in favour of the Harbor task format - #4826

Merged
adil-a merged 5 commits into
mainfrom
adasif/deprecate-harbor-agents
Nov 10, 2026
Merged

adil-a merged 5 commits into
mainfrom
adasif/deprecate-harbor-agents

Conversation

@adil-a

@adil-a adil-a commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Marks responses_api_agents/harbor_agent and responses_api_agents/harbor_agent_general as deprecated. Both are superseded by the Harbor task format, where Harbor tasks run through the Harbor environment server with NeMo Gym's own sandboxed harnesses and the harbor_oracle agent, with no Harbor dependency (PR stack starting at #3674).

What changes:

  • A deprecation banner at the top of both READMEs pointing at the Harbor path.
  • A warning logged once at server startup (model_post_init) in both agents with the same pointer.
  • The ecosystem page marks the Harbor bridge entry as deprecated.
  • One test per agent asserts the startup notice.

No behaviour change otherwise. The terminal_bench_2_1 and terminal_bench_4 servers are untouched. No removal date is set yet.

Test plan

  • responses_api_agents/harbor_agent/tests: 84 passed, 6 failed. The same 6 fail identically on a clean export of main (Daytona import path and CPU pin environment tests), unrelated to this change.
  • responses_api_agents/harbor_agent_general/tests: 54 passed.
  • pre-commit run --files <changed files>: all hooks pass.

🤖 Generated with Claude Code

@adil-a

adil-a commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 139e72b

@copy-pr-bot

copy-pr-bot Bot commented Oct 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

@svcnvidia-nemo-ci svcnvidia-nemo-ci added area:agent Agent harnesses and Responses API agent behavior docs Documentation-only updates or documentation debt needs-review PR is ready for code review and waiting on a reviewer labels Oct 21, 2026
@github-actions github-actions Bot added the sla:triage-overdue Review assignment is over the one-business-day SLA label Oct 22, 2026
ffrujeri
ffrujeri previously approved these changes Oct 26, 2026

@ffrujeri ffrujeri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adil-a

adil-a commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 01f61b6

@adil-a

adil-a commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 6c61d05

@adil-a

adil-a commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test a212902

adil-a and others added 5 commits November 6, 2026 20:44
…ur of the Harbor task format

Both Harbor bridge agents now say, in their READMEs and in a warning logged at
server startup, that they are deprecated and will be removed soon, and that new
work should run Harbor tasks through the Harbor environment server (the Harbor
task format stack starting at #3674). The ecosystem page carries the same note.
One test per agent asserts the startup notice.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Adil Asif <adasif@nvidia.com>
… server and tie removal to the remaining benchmarks

The harbor environment server is on main and the Harbor Tasks docs page exists, so the banners, the startup
warnings and the ecosystem entry link there instead of the PR stack and a folder that did not exist yet. Removal
is gated on the seven benchmarks still running through these agents (biomnibench_da, biomysterybench,
bixbench_hypothesis, genebench_pro, labbench2_pdf, legal_agent_bench, openthoughts_tblite) moving to the Harbor
task format; the notices say so instead of "removed soon".

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Adil Asif <adasif@nvidia.com>
…off moving docs pages

Review follow-up on the deprecation notices:

- about/ecosystem.mdx and the root README link "Harbor" to
  environment_servers/harbor, without a deprecation note on the ecosystem
  page; the deprecated agents' own READMEs carry it.
- The startup warnings and README banners of harbor_agent and
  harbor_agent_general point at the harbor environment server's README
  instead of the data/harbor-tasks docs page, which #5131 moves. The notices
  no longer depend on where the Harbor docs pages land.
- The deprecation tests assert the repo path and that no docs URL is named.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Adil Asif <adasif@nvidia.com>
Users of the seven built-in benchmarks that still run through harbor_agent or
harbor_agent_general did not pick the agent and have nothing to change. The
startup warning and the README banners now say those benchmarks will be
migrated to the harbor environment server and that no action is needed yet,
and keep pointing new work at the environment server. The deprecation tests
assert the no-action wording.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Adil Asif <adasif@nvidia.com>
…rbor_agent_general

skillsbench (added 27 Oct) also runs through harbor_agent_general, so the
deprecation banners now name all eight built-in benchmarks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Adil Asif <adasif@nvidia.com>
@adil-a
adil-a force-pushed the adasif/deprecate-harbor-agents branch from a212902 to 63b1ef6 Compare November 7, 2026 04:51
@adil-a

adil-a commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 63b1ef6

@adil-a
adil-a added this pull request to the merge queue Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/42666224423

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/42668966265

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 9, 2026
@adil-a
adil-a added this pull request to the merge queue Nov 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/42735213824

Merged via the queue into main with commit 7c79b15 Nov 10, 2026
69 checks passed
@adil-a
adil-a deleted the adasif/deprecate-harbor-agents branch November 10, 2026 01:42

This branch was previously deployed

1 inactive deployment
public — 63b1ef6a Deployed Nov 7, 2026 by copy-pr-bot[bot] via release / finalize / notify #10817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:agent Agent harnesses and Responses API agent behavior docs Documentation-only updates or documentation debt needs-review PR is ready for code review and waiting on a reviewer QA_verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants