Repository navigation
feat(agent): let a caller stop a running rollout and still grade it #5145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yuhezhang-ai
merged 20 commits into
NVIDIA-NeMo:main
from
gwarmstrong:georgea/gym-rollout-stop
Oct 30, 2026
+1,237
−15
Merged
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
923b105
feat(agent): stop a running rollout as a timeout
gwarmstrong 40b6b94
Merge main into georgea/gym-rollout-stop
gwarmstrong 21744ea
feat(agent): mark a stopped rollout with ng_rollout_stop instead of a…
gwarmstrong d76b7ba
fix(agent): route a rollout stop to the worker running the rollout
gwarmstrong 1622c37
fix(agent): write the expiry marker as a file within the stop timeout
gwarmstrong 5eb5621
fix(codex): grade a run stopped before its worker wrote events
gwarmstrong ed95769
docs(agent): say a rollout stop needs no session cookie
gwarmstrong 2fdb28c
fix(codex): keep the empty transcript for a stop only when none was w…
gwarmstrong c29a0af
docs(agent): scope a rollout stop to the current agent session
gwarmstrong c6302a9
fix(agent): keep a stop whose marker landed though its write failed
gwarmstrong 6c07428
test(agent): bound the expiry tests' launch waits
gwarmstrong 6ddb7cd
Merge main into georgea/gym-rollout-stop
gwarmstrong cad493c
fix(agent): bound the stop confirmation and await an unfinished marke…
gwarmstrong 92dce12
Merge remote-tracking branch 'upstream/main' into georgea/gym-rollout…
gwarmstrong a093a69
fix(agent): keep a stop deliverable when its request disconnects
gwarmstrong 2b71260
fix(agent): stop a running harness only where its upload cannot wait …
gwarmstrong f4b3839
Merge remote-tracking branch 'upstream/main' into georgea/gym-rollout…
gwarmstrong 7f6535a
Merge remote-tracking branch 'upstream/main' into georgea/gym-rollout…
gwarmstrong 417f7f1
Merge remote-tracking branch 'upstream/main' into georgea/gym-rollout…
gwarmstrong caacdbd
Merge remote-tracking branch 'upstream/main' into georgea/gym-rollout…
gwarmstrong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.