Skip to content

fix(eval): make opted-in policy timeouts final scored zeros - #5220

Merged
AdamRajfer merged 2 commits into
arajfer/failure-reportingfrom
arajfer/final-policy-timeout-20261028
Oct 28, 2026
Merged

AdamRajfer merged 2 commits into
arajfer/failure-reportingfrom
arajfer/final-policy-timeout-20261028

Conversation

@AdamRajfer

@AdamRajfer AdamRajfer commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

This adds opt-in final, scored-zero handling for policy model request timeouts. vllm_model.request_timeout_seconds bounds each engine HTTP attempt. simple_agent.final_on_model_timeout makes a /run failure final only when a complete failure report identifies the terminal model operation and every observed attempt of that operation timed out while waiting for the response.

The model client now attaches the final transport attempt as the raised error's explicit cause and distinguishes response waits from connection and pool waits. Omitted reports, earlier recovered operations, a timeout followed by HTTP 400 or a rejected response body, and connection/pool timeouts stay retryable. Judge/tool failures, cancellation, and scheduler cutoffs retain their existing handling. Request retry limits are unchanged.

The final timeout row carries a timeout event and _ng_failure_counts_as_zero. Collection and offline aggregation count the latest marked sidecar row as zero without requiring count_failure_classes_as_zero=[agent_run_error], which would also zero unrelated failures. Use route_failures_to_sidecar=true. Both new settings are disabled by default; default retry and scoring policy remain unchanged.

Validation: native checks pass 1,403 core tests, 95 simple-agent tests, 870 vLLM tests, 99 OpenAI-adapter tests, five relay tests, and all repository hooks. Production-path loopback controls on aiohttp 3.14.5 keep the slow response final zero on both adapters while timeout-then-400, timeout-then-rejected-200, never-connected, and pool-wait cases remain retryable. The source worker also proved the behavioral failures before the correction and passed its broader checks on aiohttp 3.14.4. Earlier loopback scoring/resume controls establish no new rollout for a final timeout.

The phase check uses aiohttp's ClientResponse.start traceback identity. Unknown phases and body-read timeouts after headers stay retryable; an unrecognized future aiohttp shape conservatively does not count as a model timeout. These limits matter when selecting a request deadline.

Stacked on #5072 because it consumes failure reports from model-server replies. No separate issue. Draft; exact final-head worker validation remains pending. Earlier worker/proof revisions remain separate evidence.

Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@AdamRajfer AdamRajfer self-assigned this Oct 28, 2026
@AdamRajfer AdamRajfer added area:core Shared APIs, servers, telemetry, health, and registries bug Something isn't working labels Oct 28, 2026
Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
@AdamRajfer
AdamRajfer marked this pull request as ready for review October 28, 2026 22:11
@AdamRajfer
AdamRajfer merged commit c69a5ff into arajfer/failure-reporting Oct 28, 2026
12 of 13 checks passed
@AdamRajfer
AdamRajfer deleted the arajfer/final-policy-timeout-20261028 branch October 28, 2026 22:11
@nemo-automation-bot
nemo-automation-bot Bot requested review from a team October 28, 2026 22:12

This branch was previously deployed

1 inactive deployment
public — 5e277e27 Deployed Oct 28, 2026 by copy-pr-bot[bot] via release / finalize / notify #7976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core Shared APIs, servers, telemetry, health, and registries bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant