Repository navigation
fix(eval): make opted-in policy timeouts final scored zeros - #5220
Merged
AdamRajfer merged 2 commits intoOct 28, 2026
Merged
Conversation
Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
AdamRajfer
marked this pull request as ready for review
October 28, 2026 22:11
This was referenced Oct 28, 2026
This was referenced Oct 30, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds opt-in final, scored-zero handling for policy model request timeouts. vllm_model.request_timeout_seconds bounds each engine HTTP attempt. simple_agent.final_on_model_timeout makes a /run failure final only when a complete failure report identifies the terminal model operation and every observed attempt of that operation timed out while waiting for the response.
The model client now attaches the final transport attempt as the raised error's explicit cause and distinguishes response waits from connection and pool waits. Omitted reports, earlier recovered operations, a timeout followed by HTTP 400 or a rejected response body, and connection/pool timeouts stay retryable. Judge/tool failures, cancellation, and scheduler cutoffs retain their existing handling. Request retry limits are unchanged.
The final timeout row carries a timeout event and _ng_failure_counts_as_zero. Collection and offline aggregation count the latest marked sidecar row as zero without requiring count_failure_classes_as_zero=[agent_run_error], which would also zero unrelated failures. Use route_failures_to_sidecar=true. Both new settings are disabled by default; default retry and scoring policy remain unchanged.
Validation: native checks pass 1,403 core tests, 95 simple-agent tests, 870 vLLM tests, 99 OpenAI-adapter tests, five relay tests, and all repository hooks. Production-path loopback controls on aiohttp 3.14.5 keep the slow response final zero on both adapters while timeout-then-400, timeout-then-rejected-200, never-connected, and pool-wait cases remain retryable. The source worker also proved the behavioral failures before the correction and passed its broader checks on aiohttp 3.14.4. Earlier loopback scoring/resume controls establish no new rollout for a final timeout.
The phase check uses aiohttp's ClientResponse.start traceback identity. Unknown phases and body-read timeouts after headers stay retryable; an unrecognized future aiohttp shape conservatively does not count as a model timeout. These limits matter when selecting a request deadline.
Stacked on #5072 because it consumes failure reports from model-server replies. No separate issue. Draft; exact final-head worker validation remains pending. Earlier worker/proof revisions remain separate evidence.