Repository navigation
fix(swe_pivot): stub the nemo_gym.server_runtime package the app imports - #5388
Merged
Merged
Conversation
#5214 moved the resources server base classes into nemo_gym.server_runtime, and app.py now imports them from that package. The verifier tests replace nemo_gym in sys.modules with a stub, but registered the dummy classes only under nemo_gym.server_runtime.base_resources_server, so importing app.py failed during collection and the server suite failed on main. Register the stub classes on a nemo_gym.server_runtime module, where the app looks them up. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
svcnvidia-nemo-ci
left a comment
Contributor
There was a problem hiding this comment.
SHIP
LGTM — no concerns found. The updated test shim supplies all five names imported by app.py. Checked helper-test preservation and per-server pytest subprocess isolation; production verifier behavior is unchanged.
Static review only; tests were not executed.
Note: formal approval is not available for this request, so this review is posted as a comment only.
Review generated by codex. This was a full review. Request a full review with /review reset=true.
ananthsub
enabled auto-merge
October 30, 2026 21:08
ananthsub
disabled auto-merge
October 30, 2026 21:08
Contributor
|
/review |
cmunley1
approved these changes
Oct 30, 2026
5 tasks done
cmunley1
approved these changes
Oct 30, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
swe_pivotverifier tests replacenemo_gyminsys.moduleswith a stub so they can importapp.pywithout the server stack. The stub now registers its five dummy base classes on anemo_gym.server_runtimemodule, whereapp.pyimports them from.Why
#5214 moved the resources server base classes into
nemo_gym/server_runtime/, andapp.pynow imports them from thenemo_gym.server_runtimepackage. The stub put the dummy classes only undernemo_gym.server_runtime.base_resources_server, so importingapp.pyfailed during test collection withModuleNotFoundError: No module named 'nemo_gym.server_runtime'; 'nemo_gym' is not a package. That failsUnit tests / Server suite (shard 1)onmain. No other test in the repository stubsnemo_gymthis way.Part of #5166.
Validation
swe_pivotverifier tests pass with the fix, and fail during collection without it, with the error above.pre-commit runon the changed file.Rollout evidence: N/A. Test setup only; the server's code does not change.