Repository navigation
build(opencode_search): add the missing component lock files - #5629
Conversation
The opencode_search resources server shipped with a requirements.txt and no pyproject.toml or uv.lock, so the lock check and the component dependency tests fail on main. It now has a pyproject.toml like the other resources servers (nemo-gym[dev,sandbox] from the repo, the shared uv policy written by scripts/component_locks.py) and its uv.lock, and the requirements.txt is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
|
/ok to test a9ae8e4 |
svcnvidia-nemo-ci
left a comment
There was a problem hiding this comment.
SHIP
LGTM — no concerns found. The manifest preserves nemo-gym[dev,sandbox] from the removed requirement and matches the shared component policy. The lockfile records the corresponding editable dependency and optional telemetry extra.
I reviewed all three changed files and traced the affected installation, launch, and test paths. This was static inspection; I didn't execute uv, tests, or rollouts.
Note: formal approval is not available for this request, so this review is posted as a comment only.
Review generated by codex. This was a full review. Request a full review with /review reset=true.
|
Main is red on Check locks and the dependency tests since #4935 landed without these two files, so every open PR inherits the failure. This only adds the lock files for the new server, no code change. pyproject/uv.lock are owned by the automation team, so one approval from there is needed before it can go in. |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/41917659377 |
|
@AdamRajfer thanks for the fix. |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/41920926776 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/41923492904 |
Picks up the opencode_search lock files (#5629) that the lock check and dependency tests need. No conflicts; git merged every file on its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
Picks up the opencode_search lock files (#5629) that the lock check and dependency tests need. No conflicts; git merged every file on its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
…essions Picks up the opencode_search component lock files (#5629) so the component-lock checks pass on this branch. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Add the missing component lock files for
opencode_searchso the lock check and the dependency tests pass.The
opencode_searchresources server (#4935) shipped with arequirements.txtand nopyproject.tomloruv.lock. Since managed environments are locked, that fails on main:Missing pyproject.tomlforresources_servers/opencode_search.tests/unit_tests/tooling/test_component_dependencies.py, includingtest_servers_declare_locked_dependenciesandtest_servers_do_not_use_requirements_txt.Every PR merged with current main inherits those failures.
Change
resources_servers/opencode_search/pyproject.toml, laid out like the other resources servers that depend onnemo-gym[dev,sandbox], with the shared uv policy written byscripts/component_locks.py --update.resources_servers/opencode_search/uv.lock, generated by the same script.requirements.txtremoved. Its only line was-e nemo-gym[dev,sandbox] @ ../.., which the newpyproject.tomldeclares.No code changes.
Validation
scripts/component_locks.pycheck forresources_servers/opencode_search: passes (176 packages resolved).tests/unit_tests/tooling/test_component_dependencies.py: all pass; the five fail on main.uv sync --lockedfor the server, thenresources_servers/opencode_search/tests: 12 passed.🤖 Generated with Claude Code