Skip to content

build(opencode_search): add the missing component lock files - #5629

Merged
AdamRajfer merged 1 commit into
mainfrom
arajfer/opencode-search-locks
Nov 4, 2026
Merged

AdamRajfer merged 1 commit into
mainfrom
arajfer/opencode-search-locks

Conversation

@AdamRajfer

Copy link
Copy Markdown
Contributor

Add the missing component lock files for opencode_search so the lock check and the dependency tests pass.

The opencode_search resources server (#4935) shipped with a requirements.txt and no pyproject.toml or uv.lock. Since managed environments are locked, that fails on main:

  • Check locks (both OSes): Missing pyproject.toml for resources_servers/opencode_search.
  • Core tests: five tests in tests/unit_tests/tooling/test_component_dependencies.py, including test_servers_declare_locked_dependencies and test_servers_do_not_use_requirements_txt.

Every PR merged with current main inherits those failures.

Change

  • resources_servers/opencode_search/pyproject.toml, laid out like the other resources servers that depend on nemo-gym[dev,sandbox], with the shared uv policy written by scripts/component_locks.py --update.
  • resources_servers/opencode_search/uv.lock, generated by the same script.
  • requirements.txt removed. Its only line was -e nemo-gym[dev,sandbox] @ ../.., which the new pyproject.toml declares.

No code changes.

Validation

  • scripts/component_locks.py check for resources_servers/opencode_search: passes (176 packages resolved).
  • tests/unit_tests/tooling/test_component_dependencies.py: all pass; the five fail on main.
  • uv sync --locked for the server, then resources_servers/opencode_search/tests: 12 passed.

🤖 Generated with Claude Code

The opencode_search resources server shipped with a requirements.txt and
no pyproject.toml or uv.lock, so the lock check and the component
dependency tests fail on main. It now has a pyproject.toml like the other
resources servers (nemo-gym[dev,sandbox] from the repo, the shared uv
policy written by scripts/component_locks.py) and its uv.lock, and the
requirements.txt is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
@AdamRajfer
AdamRajfer requested a review from a team as a code owner November 4, 2026 20:44
@AdamRajfer AdamRajfer self-assigned this Nov 4, 2026
@AdamRajfer

Copy link
Copy Markdown
Contributor Author

/ok to test a9ae8e4

@svcnvidia-nemo-ci svcnvidia-nemo-ci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP

LGTM — no concerns found. The manifest preserves nemo-gym[dev,sandbox] from the removed requirement and matches the shared component policy. The lockfile records the corresponding editable dependency and optional telemetry extra.

I reviewed all three changed files and traced the affected installation, launch, and test paths. This was static inspection; I didn't execute uv, tests, or rollouts.

Note: formal approval is not available for this request, so this review is posted as a comment only.

Review generated by codex. This was a full review. Request a full review with /review reset=true.

@AdamRajfer
AdamRajfer requested review from kajalj22 and ko3n1g November 4, 2026 21:32
@AdamRajfer

Copy link
Copy Markdown
Contributor Author

Main is red on Check locks and the dependency tests since #4935 landed without these two files, so every open PR inherits the failure. This only adds the lock files for the new server, no code change. pyproject/uv.lock are owned by the automation team, so one approval from there is needed before it can go in.

@AdamRajfer
AdamRajfer added this pull request to the merge queue Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/41917659377

@abhibha-nvidia

abhibha-nvidia commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

@AdamRajfer thanks for the fix.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 4, 2026
@AdamRajfer
AdamRajfer added this pull request to the merge queue Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/41920926776

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/41923492904

Merged via the queue into main with commit 653846f Nov 4, 2026
60 of 63 checks passed
@AdamRajfer
AdamRajfer deleted the arajfer/opencode-search-locks branch November 4, 2026 22:29
AdamRajfer added a commit that referenced this pull request Nov 4, 2026
Picks up the opencode_search lock files (#5629) that the lock check and dependency tests need. No conflicts; git merged every file on its own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
AdamRajfer added a commit that referenced this pull request Nov 4, 2026
Picks up the opencode_search lock files (#5629) that the lock check and dependency tests need. No conflicts; git merged every file on its own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
yaoyu-33 added a commit that referenced this pull request Nov 5, 2026
…essions

Picks up the opencode_search component lock files (#5629) so the component-lock checks pass on this branch.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

This branch was previously deployed

1 inactive deployment
public — a9ae8e48 Deployed Nov 4, 2026 by copy-pr-bot[bot] via release / finalize / notify #10139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants