[Nemo1] Generate sharded optimizer state dicts only if needed for saving#11451
Merged
ananthsub merged 1 commit intoNVIDIA-NeMo:mainfrom Dec 3, 2024
Merged
[Nemo1] Generate sharded optimizer state dicts only if needed for saving#11451ananthsub merged 1 commit intoNVIDIA-NeMo:mainfrom
ananthsub merged 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
debug-ckpt-oom
branch
from
764b791 to
0a643ee
Compare
Contributor
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
maanug-nv
approved these changes
Dec 3, 2024
Collaborator
maanug-nv
left a comment
maanug-nv
left a comment
There was a problem hiding this comment.
LGTM. should not functionally change ckpt content, just perf improvement correct?
Collaborator
Author
That's correct. The ckpt contents are the same, and this is strictly a perf improvement |
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
youngeunkwon0405
pushed a commit
to youngeunkwon0405/NeMo
that referenced
this pull request
Feb 10, 2025
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
If not saving optimizers in the checkpoint, don't generate the sharded optimizer state dict, as it will ultimately be discarded. The ckpt contents are the same, and this is strictly a perf improvement
Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information