Skip to content

removed the line which caused a problem in nfa_tutorial#11710

Merged
nithinraok merged 1 commit intomainfrom
nemo_forced_aligner_tutorial_bugfix
Dec 25, 2024
Merged

removed the line which caused a problem in nfa_tutorial#11710
nithinraok merged 1 commit intomainfrom
nemo_forced_aligner_tutorial_bugfix

Conversation

@Ssofja
Copy link
Collaborator

@Ssofja Ssofja commented Dec 24, 2024

What does this PR do ?

This PR fixes the bug which was noticed during the usage of tutorials/tools/NeMo_Forced_Aligner_Tutorial.ipynb
Collection: [ASR]

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@Ssofja Ssofja requested a review from nithinraok December 24, 2024 16:52
@github-actions github-actions bot added the ASR label Dec 24, 2024
@Ssofja Ssofja added bug Something isn't working r2.1.0 Run CICD labels Dec 24, 2024
@Ssofja Ssofja force-pushed the nemo_forced_aligner_tutorial_bugfix branch from 4095920 to b354106 Compare December 24, 2024 16:59
Copy link
Member

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

[🤖]: Hi @Ssofja 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Signed-off-by: Ssofja <sofiakostandian@gmail.com>
@Ssofja Ssofja force-pushed the nemo_forced_aligner_tutorial_bugfix branch from b354106 to 7958b00 Compare December 25, 2024 13:05
@nithinraok nithinraok enabled auto-merge (squash) December 25, 2024 14:41
@Ssofja Ssofja added Run CICD and removed Run CICD labels Dec 25, 2024
@github-actions
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_models
nemo/collections/asr/models/hybrid_rnnt_ctc_models.py:716:0: C0301: Line too long (141/119) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_models.py:717:0: C0301: Line too long (139/119) (line-too-long)
nemo/collections/asr/models/hybrid_rnnt_ctc_models.py:16:0: W0611: Unused import json (unused-import)
nemo/collections/asr/models/hybrid_rnnt_ctc_models.py:17:0: W0611: Unused import os (unused-import)
nemo/collections/asr/models/hybrid_rnnt_ctc_models.py:18:0: W0611: Unused import tempfile (unused-import)
nemo/collections/asr/models/hybrid_rnnt_ctc_models.py:24:0: W0611: Unused tqdm imported from tqdm.auto (unused-import)

-----------------------------------
Your code has been rated at 9.82/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@github-actions
Copy link
Contributor

[🤖]: Hi @Ssofja 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@nithinraok nithinraok merged commit 3394c22 into main Dec 25, 2024
@nithinraok nithinraok deleted the nemo_forced_aligner_tutorial_bugfix branch December 25, 2024 21:17
ko3n1g pushed a commit that referenced this pull request Dec 25, 2024
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Ssofja added a commit that referenced this pull request Dec 26, 2024
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
malay-nagda pushed a commit that referenced this pull request Dec 31, 2024
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Ssofja added a commit that referenced this pull request Jan 7, 2025
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
…11710)

Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASR bug Something isn't working r2.1.0 Run CICD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants