Conversation
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
cuichenx
left a comment
There was a problem hiding this comment.
LGTM, just some documentation notes. It would be good to briefly describe the metadata format after self.pack_metadata = json.load(f)
nemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
1805e89 to
5ec8a60
Compare
Signed-off-by: jiemingz <jiemingz@users.noreply.github.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
|
LGTM |
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
|
[🤖]: Hi @jiemingz 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
* fix packing pad for val Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * address comments Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: jiemingz <jiemingz@users.noreply.github.com> * fix padding Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: jiemingz <jiemingz@users.noreply.github.com> Co-authored-by: jiemingz <jiemingz@users.noreply.github.com>
* fix packing pad for val Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * address comments Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: jiemingz <jiemingz@users.noreply.github.com> * fix padding Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: jiemingz <jiemingz@users.noreply.github.com> Co-authored-by: jiemingz <jiemingz@users.noreply.github.com> Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
* fix packing pad for val Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * address comments Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: jiemingz <jiemingz@users.noreply.github.com> * fix padding Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: jiemingz <jiemingz@users.noreply.github.com> Co-authored-by: jiemingz <jiemingz@users.noreply.github.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information