Merged
Conversation
Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com>
Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com>
Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com>
yaoyu-33
approved these changes
Jan 22, 2025
parthmannan
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Create test_phi3.py Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com> * Update test_phi3.py with correcting minor typo Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com> --------- Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com> Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com> Co-authored-by: mayani-nv <mayani-nv@users.noreply.github.com> Signed-off-by: Parth Mannan <pmannan@nvidia.com>
abhinavg4
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Create test_phi3.py Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com> * Update test_phi3.py with correcting minor typo Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com> --------- Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com> Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com> Co-authored-by: mayani-nv <mayani-nv@users.noreply.github.com> Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405
pushed a commit
to youngeunkwon0405/NeMo
that referenced
this pull request
Feb 10, 2025
* Create test_phi3.py Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com> * Update test_phi3.py with correcting minor typo Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com> * Apply isort and black reformatting Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com> --------- Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com> Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com> Co-authored-by: mayani-nv <mayani-nv@users.noreply.github.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating unit tests for the Phi3 model