Skip to content

check restore_config first#11890

Merged
akoumpa merged 1 commit intomainfrom
akoumparouli/mini_fix_autoresume
Jan 20, 2025
Merged

check restore_config first#11890
akoumpa merged 1 commit intomainfrom
akoumparouli/mini_fix_autoresume

Conversation

@akoumpa
Copy link
Collaborator

@akoumpa akoumpa commented Jan 19, 2025

What does this PR do ?

_find_trainer_ckpt_path crashes if it restores from an imported ckpt with a restore config.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
context_path = trainer_ckpt_path.base_model_path
else:
context_path = self.get_context_path(model)
model = _try_restore_tokenizer(model, context_path)

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable model is not used.
@akoumpa akoumpa added Run CICD and removed Run CICD labels Jan 19, 2025
@github-actions
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.lightning.resume
nemo/lightning/resume.py:99:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/resume.py:102:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/resume.py:265:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/resume.py:278:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.77/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@github-actions
Copy link
Contributor

[🤖]: Hi @akoumpa 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@akoumpa akoumpa marked this pull request as ready for review January 20, 2025 19:12
@akoumpa akoumpa requested a review from marcromeyn January 20, 2025 19:13
@akoumpa akoumpa merged commit 0075ed0 into main Jan 20, 2025
258 of 400 checks passed
@akoumpa akoumpa deleted the akoumparouli/mini_fix_autoresume branch January 20, 2025 19:14
cuichenx added a commit that referenced this pull request Jan 22, 2025
akoumpa pushed a commit that referenced this pull request Jan 22, 2025
This reverts commit 0075ed0.

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa added a commit that referenced this pull request Jan 22, 2025
* Revert "check restore_config first (#11890)"

This reverts commit 0075ed0.

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* add test that would have caught it

Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix param validation

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
parthmannan pushed a commit that referenced this pull request Jan 28, 2025
* Revert "check restore_config first (#11890)"

This reverts commit 0075ed0.

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* add test that would have caught it

Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix param validation

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Parth Mannan <pmannan@nvidia.com>
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
* Revert "check restore_config first (#11890)"

This reverts commit 0075ed0.

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* add test that would have caught it

Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix param validation

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
…ror (NVIDIA-NeMo#11914)

* Revert "check restore_config first (NVIDIA-NeMo#11890)"

This reverts commit 0075ed0.

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* add test that would have caught it

Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix param validation

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants