Skip to content

nemo ux expert tensor parallel#11903

Merged
akoumpa merged 4 commits intomainfrom
akoumparouli/nemo_ux_expert_tensor_parallel
Jan 21, 2025
Merged

nemo ux expert tensor parallel#11903
akoumpa merged 4 commits intomainfrom
akoumparouli/nemo_ux_expert_tensor_parallel

Conversation

@akoumpa
Copy link
Collaborator

@akoumpa akoumpa commented Jan 20, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_expert_tensor_parallel branch from f668f6e to f75ee5c Compare January 20, 2025 19:21
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_expert_tensor_parallel branch 7 times, most recently from 6f943aa to 6dd3e81 Compare January 20, 2025 19:29
@akoumpa akoumpa changed the title Akoumparouli/nemo ux expert tensor parallel nemo ux expert tensor parallel Jan 20, 2025
@akoumpa akoumpa added Run CICD and removed audio labels Jan 20, 2025
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_expert_tensor_parallel branch from 91b6e92 to 1785278 Compare January 21, 2025 03:34
@akoumpa akoumpa marked this pull request as ready for review January 21, 2025 03:34
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
@akoumpa akoumpa added Run CICD and removed Run CICD labels Jan 21, 2025
@github-actions
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.lightning._strategy_lib
nemo/lightning/_strategy_lib.py:577:0: C0301: Line too long (130/119) (line-too-long)
nemo/lightning/_strategy_lib.py:35:0: C0115: Missing class docstring (missing-class-docstring)
nemo/lightning/_strategy_lib.py:36:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/_strategy_lib.py:143:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/_strategy_lib.py:170:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/_strategy_lib.py:206:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/_strategy_lib.py:519:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/_strategy_lib.py:602:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/_strategy_lib.py:615:4: C0115: Missing class docstring (missing-class-docstring)
************* Module nemo.lightning.megatron_init
nemo/lightning/megatron_init.py:267:0: C0301: Line too long (122/119) (line-too-long)
nemo/lightning/megatron_init.py:268:0: C0301: Line too long (133/119) (line-too-long)
nemo/lightning/megatron_init.py:269:0: C0301: Line too long (121/119) (line-too-long)
nemo/lightning/megatron_init.py:372:0: C0301: Line too long (166/119) (line-too-long)
nemo/lightning/megatron_init.py:88:0: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.lightning.pytorch.strategies.megatron_strategy
nemo/lightning/pytorch/strategies/megatron_strategy.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.utils.app_state
nemo/utils/app_state.py:458:0: C0301: Line too long (138/119) (line-too-long)
nemo/utils/app_state.py:466:0: C0301: Line too long (135/119) (line-too-long)
nemo/utils/app_state.py:23:0: C0115: Missing class docstring (missing-class-docstring)
nemo/utils/app_state.py:29:0: C0115: Missing class docstring (missing-class-docstring)
nemo/utils/app_state.py:273:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/app_state.py:726:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/app_state.py:736:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/app_state.py:745:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/app_state.py:750:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/app_state.py:756:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/app_state.py:764:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/app_state.py:772:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.79/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@github-actions
Copy link
Contributor

[🤖]: Hi @akoumpa 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Copy link
Collaborator

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@akoumpa akoumpa merged commit 7d74e71 into main Jan 21, 2025
211 of 213 checks passed
@akoumpa akoumpa deleted the akoumparouli/nemo_ux_expert_tensor_parallel branch January 21, 2025 16:27
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
* etp

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix test

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* import guard

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* etp

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix test

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* import guard

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
@akoumpa akoumpa added the moe label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants