Skip to content

ci: Small fix to bump workflow#11919

Merged
ko3n1g merged 1 commit intomainfrom
ko3n1g/ci/adjust-bump-mcore
Jan 22, 2025
Merged

ci: Small fix to bump workflow#11919
ko3n1g merged 1 commit intomainfrom
ko3n1g/ci/adjust-bump-mcore

Conversation

@ko3n1g
Copy link
Contributor

@ko3n1g ko3n1g commented Jan 22, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

f
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested a review from pablo-garay as a code owner January 22, 2025 08:53
@github-actions github-actions bot added the CI label Jan 22, 2025
@ko3n1g ko3n1g merged commit 08aeb80 into main Jan 22, 2025
19 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/adjust-bump-mcore branch January 22, 2025 08:53
parthmannan pushed a commit that referenced this pull request Jan 28, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Parth Mannan <pmannan@nvidia.com>
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant