Skip to content

Update transcribe_utils.py#11984

Merged
stevehuang52 merged 1 commit intomainfrom
stevehuang52-patch-1
Jan 29, 2025
Merged

Update transcribe_utils.py#11984
stevehuang52 merged 1 commit intomainfrom
stevehuang52-patch-1

Conversation

@stevehuang52
Copy link
Collaborator

Add skipping empty lines when reading manifest

add skipping empty lines when reading manifest

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Copy link
Member

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehuang52 stevehuang52 enabled auto-merge (squash) January 29, 2025 03:26
@github-actions
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.asr.parts.utils.transcribe_utils
nemo/collections/asr/parts/utils/transcribe_utils.py:183:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/parts/utils/transcribe_utils.py:351:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/parts/utils/transcribe_utils.py:651:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/asr/parts/utils/transcribe_utils.py:666:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/parts/utils/transcribe_utils.py:674:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/parts/utils/transcribe_utils.py:677:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/parts/utils/transcribe_utils.py:685:0: C0115: Missing class docstring (missing-class-docstring)

-----------------------------------
Your code has been rated at 9.82/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@github-actions
Copy link
Contributor

[🤖]: Hi @stevehuang52 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@stevehuang52 stevehuang52 merged commit 25ec4e9 into main Jan 29, 2025
210 of 212 checks passed
@stevehuang52 stevehuang52 deleted the stevehuang52-patch-1 branch January 29, 2025 06:39
BoxiangW pushed a commit that referenced this pull request Feb 7, 2025
add skipping empty lines when reading manifest

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
add skipping empty lines when reading manifest

Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants