fix the issue during batched inference of Sortformer diarizer#12047
Merged
fix the issue during batched inference of Sortformer diarizer#12047
Conversation
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
…NeMo into fix/sortformer_batch_len
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12047 +/- ##
=======================================
Coverage 30.43% 30.43%
=======================================
Files 1400 1401 +1
Lines 177498 177572 +74
Branches 27203 27213 +10
=======================================
+ Hits 54016 54041 +25
- Misses 119358 119406 +48
- Partials 4124 4125 +1 ☔ View full report in Codecov by Sentry. |
Contributor
|
[🤖]: Hi @tango4j 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Feb 20, 2025
…-NeMo#12047) * Added changes that fix the issue during batched inference Signed-off-by: Taejin Park <tango4j@gmail.com> * Adding changes to prevent ghost output Signed-off-by: Taejin Park <tango4j@gmail.com> --------- Signed-off-by: Taejin Park <tango4j@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes the ghost timestamps issue occurs during batched inference of Sortformer model.
Collection:
ASR
Changelog
The following files are changed:
nemo/collections/asr/data/audio_to_diar_label_lhotse.pynemo/collections/asr/models/sortformer_diar_models.pynemo/collections/asr/modules/sortformer_modules.pyUsage
GitHub Actions CI
Run CICD
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in NeMo ASR
Additional Information
Sortformer Train/Inference