Improve NEST GPU Utilization 1/N#14086
Merged
stevehuang52 merged 1 commit intoNVIDIA-NeMo:mainfrom Jul 2, 2025
Merged
Conversation
Signed-off-by: Mahmoud Ashraf <hassouna97.ma@gmail.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Mahmoud Ashraf <hassouna97.ma@gmail.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Mahmoud Ashraf <hassouna97.ma@gmail.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Mahmoud Ashraf <hassouna97.ma@gmail.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
Signed-off-by: Mahmoud Ashraf <hassouna97.ma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is among a series aimed to improve the training speed and GPU utilization of NEST models #13619
This PR Simplifies
__getitem__method ofLhotseAudioNoiseDatasetSince Lhotse cuts are returned already stacked and collated, there is no need of using
AudioNoiseItemto split them and then stack them again in_audio_noise_collate_fnsincetorch.stackcalls are expensive for large tensors, only the noise tensors need to be stackedcc @pzelasko @stevehuang52