Skip to content

Megatron FSDP r2.5.0 cherry-pick#14922

Merged
chtruong814 merged 11 commits intor2.5.0from
boxiagw/megatron_fsdp_cherry_pick
Oct 16, 2025
Merged

Megatron FSDP r2.5.0 cherry-pick#14922
chtruong814 merged 11 commits intor2.5.0from
boxiagw/megatron_fsdp_cherry_pick

Conversation

@BoxiangW
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Selvaraj Anandaraj and others added 7 commits October 13, 2025 12:26
Signed-off-by: Selvaraj Anandaraj <selvaraja@login-ptyche01.ptyche.clusters.nvidia.com>
Signed-off-by: jianbinc <shjwudp@gmail.com>
Signed-off-by: jianbinc <shjwudp@gmail.com>
Signed-off-by: jianbinc <shjwudp@gmail.com>
formt code

Signed-off-by: jianbinc <shjwudp@gmail.com>
…ore 0.14

Signed-off-by: jianbinc <shjwudp@gmail.com>
Signed-off-by: jianbinc <shjwudp@gmail.com>
Signed-off-by: shjwudp <shjwudp@users.noreply.github.com>
@BoxiangW BoxiangW force-pushed the boxiagw/megatron_fsdp_cherry_pick branch from 23c3af9 to 438cef0 Compare October 13, 2025 19:26
Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com>
ko3n1g
ko3n1g previously approved these changes Oct 13, 2025
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
chtruong814
chtruong814 previously approved these changes Oct 16, 2025
@github-actions github-actions bot removed the Run CICD label Oct 16, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
@chtruong814 chtruong814 disabled auto-merge October 16, 2025 13:06
@chtruong814 chtruong814 merged commit 7d643af into r2.5.0 Oct 16, 2025
556 of 566 checks passed
@chtruong814 chtruong814 deleted the boxiagw/megatron_fsdp_cherry_pick branch October 16, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants