Skip to content

Clean ASR older and non-maintained models and its respective modules#15507

Merged
nithinraok merged 18 commits intomainfrom
clean_asr
Mar 23, 2026
Merged

Clean ASR older and non-maintained models and its respective modules#15507
nithinraok merged 18 commits intomainfrom
clean_asr

Conversation

@nithinraok
Copy link
Member

@nithinraok nithinraok commented Mar 17, 2026

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Remove deprecated and unmaintained ASR model architectures

Collection: ASR

Changelog

  • Remove QuartzNet model, configs, pretrained model entries, and related tests
  • Remove Squeezeformer encoder, modules, configs, pretrained model entries, and tests
  • Remove ContextNet configs and pretrained model entries
  • Remove CitriNet configs, SSL configs, and pretrained model entries
  • Remove MSDD Diarizer models and related tests
  • Remove SLU models and related tests
  • Remove examples/asr/experimental/ directory
  • Remove K2 model classes (EncDecK2RnntSeqModelBPE, k2 aligner, graph compilers/decoders, lattice losses, etc.), keeping only core K2 loss/utility code (graph_transducer.py, rnnt_logprobs.py, rnnt_logprobs_triton.py, w_transducer.py)
  • Replace QuartzNet references in remaining tests with supported models (e.g., FastConformer)

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

nithinraok and others added 8 commits March 17, 2026 19:36
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
@nithinraok nithinraok changed the title initial clean up Clean ASR older and non-maintained models and its respective modules Mar 18, 2026
@github-actions github-actions bot removed the Run CICD label Mar 18, 2026
pzelasko
pzelasko previously approved these changes Mar 18, 2026
@github-actions github-actions bot removed the Run CICD label Mar 18, 2026
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
nithinraok and others added 4 commits March 19, 2026 09:33
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
tango4j and others added 2 commits March 19, 2026 15:50
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
@tango4j
Copy link
Collaborator

tango4j commented Mar 20, 2026

I have checked and fixed the deprecated MSDD-related codes and documents.
Also, updated diarization documents with the latest Sortformer models on HF.
I asked @ipmedenn to double check if there is any issues or critical missing part.
But I think if test passes, speaker diarization part is good to go.

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@github-actions github-actions bot removed the Run CICD label Mar 20, 2026
Copy link
Collaborator

@artbataev artbataev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All changes look reasonable.
Please fix failing tests.
Special thanks for removing old k2-related code!

@nithinraok
Copy link
Member Author

Two failed tests are fixed on main. So merging this PR>

@nithinraok nithinraok merged commit d9e94a1 into main Mar 23, 2026
200 of 203 checks passed
@nithinraok nithinraok deleted the clean_asr branch March 23, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants