Fix e2e nightly tests: move shared utils out of conftest.py#15519
Merged
Fix e2e nightly tests: move shared utils out of conftest.py#15519
Conversation
CI runs pytest from the repo root, so `from conftest import prepare_for_training_step` raises ModuleNotFoundError in every test_model_training_step test (~58 L2_Model_Support jobs). Move the shared utility to a proper `e2e_utils` module and add `tests/e2e_nightly` to pytest's `pythonpath` in pyproject.toml so the module is importable regardless of working directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Member
|
/claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
nithinraok
approved these changes
Mar 18, 2026
chtruong814
approved these changes
Mar 18, 2026
Collaborator
Author
|
Merging to repair many nightly tests quickly - I'll fix canary-qwen test separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
CI runs pytest from the repo root, so
from conftest import prepare_for_training_stepraises ModuleNotFoundError in every test_model_training_step test (~58 L2_Model_Support jobs).Move the shared utility to a proper
e2e_utilsmodule and addtests/e2e_nightlyto pytest'spythonpathin pyproject.toml so the module is importable regardless of working directory.Collection: all
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information