Repository navigation
fix: fix fp8 hf_config_overrides bug - #2904
Merged
Merged
Conversation
Signed-off-by: Anna Shors <ashors@nvidia.com>
Contributor
Author
|
/ok to test a6979ab |
Contributor
Author
|
/ok to test 6b3e868 |
Contributor
Author
|
/ok to test 3b81154 |
arnavk-nvidia
previously approved these changes
Jun 24, 2026
terrykong
reviewed
Jun 26, 2026
terrykong
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! The change is correct and well-scoped.
Context worth capturing: this bug was already fixed once and silently reverted, so it's effectively a re-fix rather than a new fix:
- #1413 (2025-10-25) added the original
hf_overridesmerge. - #2188 "Add YaRN rope scaling support" (2026-04-04) removed those merge lines while refactoring the surrounding block, reintroducing the clobber.
- This PR (#2904) restores the merge.
Because there's no test covering fp8 + hf_config_overrides, the regression rode in unnoticed. Left an inline note suggesting a small regression test so this doesn't return a third time. Otherwise LGTM.
Generated by Claude Code
Signed-off-by: ashors1 <ashors@nvidia.com>
Contributor
Author
|
/ok to test 496146a |
Contributor
Author
|
/ok to test 2b0289a |
terrykong
enabled auto-merge (squash)
July 9, 2026 18:31
terrykong
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
When
hf_config_overridesand fp8 are both set, the user providedhf_config_overridesget overwritten with the fp8hf_overrides. This PR adds to the existinghf_overridesif it exists to avoid overwriting the user-provided settings.Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information