Repository navigation
Conversation
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
…n-dspark-objective-v3-fixes Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Contributor
Author
|
/ok to test c6299c4 |
…n-dspark-objective-v3-fixes Signed-off-by: seonjinn <sna@nvidia.com>
Contributor
Author
|
/ok to test c39e31e |
…n-dspark-objective-v3-20260820 Signed-off-by: seonjinn <sna@nvidia.com>
Block draft co-training can train at the baseline TP4 layout. Run the DSpark objective and provider TP tests at TP2 and TP4 to cover the split-vocab paths at both sizes. Signed-off-by: seonjinn <sna@nvidia.com>
Contributor
Author
|
/ok to test c608fd4 |
Signed-off-by: seonjinn <sna@nvidia.com> # Conflicts: # docs/index.md
Contributor
Author
|
/ok to test e96a75f |
yuki-97
reviewed
Nov 5, 2026
yuki-97
left a comment
Contributor
There was a problem hiding this comment.
Merge blockers — please rebase on main; the PR is 22 commits behind and the "Check if PR branch is up to date" job allows at most 10.
Thanks for adding tiled DSpark CE, TV, and confidence objectives with a stop-gradient target head.
The reported four-GPU GB200 checks and extensive self-review are appreciated; the posted results make the validation scope clear.
Scope: DSpark objectives, the provider, documentation, and shared coverage changes, at e96a75f.
Checked:
- Loss math — global normalization and TP-summed hidden and Markov gradients match the dense-reference contract.
- Consumer integration — #3757 consumes the combined tensors through the common draft-loss wrapper; the dedicated component interfaces have only test consumers.
- Validation — current-head CI logs confirm objective, provider, coverage lifecycle, TP2/DP2, and TP2 checkpoint cases passed; TP4 cases skip on two-GPU runners. Downstream e2e runs remain author-reported.
Remaining comments are on:
- Removing the dedicated statistics interfaces that have only test consumers while preserving validation and gradient coverage.
- Removing the shared coverage changes from this PR and landing any needed fixes separately, as previously requested on #3715 and #3711.
nit
- Shorten the confidence-path comment and remove its unsupported future guarantee.
- Add the downstream integration pointer to the provider factory.
Generated by Codex
Signed-off-by: seonjinn <sna@nvidia.com>
…n-dspark-objective-v3-fixes Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Contributor
Author
|
/ok to test 7fe724d |
seonjinn
added a commit
to seonjinn/RL
that referenced
this pull request
Nov 7, 2026
…rf-20261020 Signed-off-by: seonjinn <sna@nvidia.com>
seonjinn
added a commit
to seonjinn/RL
that referenced
this pull request
Nov 7, 2026
Signed-off-by: seonjinn <sna@nvidia.com>
yuki-97
approved these changes
Nov 10, 2026
yuki-97
enabled auto-merge (squash)
November 10, 2026 13:12
Contributor
|
/ok to test 8bcb841 |
jthomson04
added a commit
to jthomson04/RL
that referenced
this pull request
Nov 12, 2026
Brings NVIDIA-NeMo#3726 (DSpark tiled objectives), NVIDIA-NeMo#4882 (reward_shaping on the SingleController path) and NVIDIA-NeMo#5130 (in-loss sequence filtering for PPO). No conflicts. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
seonjinn
added a commit
to seonjinn/RL
that referenced
this pull request
Nov 13, 2026
Signed-off-by: seonjinn <sna@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Covers DSpark objectives, heads, providers, and distributed objective tests. Training-loop configuration is handled downstream.
pyproject.tomlsetssource_pkgs,tests/run_unit.shpasses--cov-config, andtests/unit/conftest.pykeeps the session coverage total.tests/unit/test_unit_coverage_lifecycle.pytests this.Validation
d3d0cc7586. Review fixes inc6299c47c0.tests/unit/algorithms/test_dspark_objective.py51 passed. GPU TP/DP tests not run locally. CI is pending.Prior focused evidence
6392604: 42 focused tests passed. The local objective suite passed 32 tests; earlier TP/DP and real-MCore checkpoint coverage also passed on 4×GB200.Dependencies
Depends on #3703 and #3711.