Skip to content

[Superseded] Final SA-V + CapRL video GRPO stack - #4180

Closed
ehosseiniasl wants to merge 2 commits into
ehsan/super35-video-runtime-compatfrom
ehsan/super35-video-only-final
Closed

ehosseiniasl wants to merge 2 commits into
ehsan/super35-video-runtime-compatfrom
ehsan/super35-video-only-final

Conversation

@ehosseiniasl

@ehosseiniasl ehosseiniasl commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Superseded — do not review or merge this PR.

The implementation is now split into four smaller PRs:

  1. feat(vlm): support mixed SA-V and CapRL video manifests #4187 — mixed SA-V/CapRL data support
  2. fix(vlm): align training media with rollout placeholders #4188 — rollout/media alignment
  3. fix(video): load frozen vision weights and disable unused MTP #4189 — frozen-vision and MTP runtime compatibility
  4. chore(video): add final SA-V + CapRL recipe and launchers #4190 — final recipe, launchers, and Gym pin

Please review and merge them in that order. The combined code is unchanged from this original implementation.

@ehosseiniasl
ehosseiniasl requested review from a team as code owners September 17, 2026 21:53
@copy-pr-bot

copy-pr-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ehosseiniasl
ehosseiniasl requested a review from a team as a code owner September 17, 2026 21:59
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/super35-video-only-final branch from d9aefed to f2dd5e6 Compare September 17, 2026 22:13
@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: f2dd5e6 (PR #4180 from ehsan/super35-video-only-final)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of super-v3.5-posttraining branch (fast-forward)

All submodule changes look good! ✨

@ehosseiniasl
ehosseiniasl marked this pull request as draft September 17, 2026 23:31
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/super35-video-only-final branch from f2dd5e6 to c7e1ac7 Compare September 17, 2026 23:43
@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: c7e1ac7 (PR #4180 from ehsan/super35-video-only-final)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of super-v3.5-posttraining branch (fast-forward)

All submodule changes look good! ✨

@ehosseiniasl ehosseiniasl changed the title feat(vlm): add final SA-V + CapRL video GRPO stack chore(video): add final SA-V + CapRL recipe and launchers Sep 17, 2026
@ehosseiniasl
ehosseiniasl changed the base branch from super-v3.5-posttraining to ehsan/super35-video-runtime-compat September 17, 2026 23:47
Add the combined video-and-tracking recipe plus matched step-120 launchers, including rollout-compatible square video grids, five-step checkpoint cadence, native no-pruning retention, and profile-band labeling.

Signed-off-by: Ehsan Hosseini Asl <ehosseiniasl@nvidia.com>
Signed-off-by: Ehsan Hosseini Asl <ehosseiniasl@nvidia.com>
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/super35-video-only-final branch from c7e1ac7 to 88ff8b4 Compare September 17, 2026 23:52
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/super35-video-runtime-compat branch from 80a79bb to 3cdb351 Compare September 17, 2026 23:52
@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 88ff8b4 (PR #4180 from ehsan/super35-video-only-final)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of ehsan/super35-video-runtime-compat branch (fast-forward)

All submodule changes look good! ✨

1 similar comment
@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 88ff8b4 (PR #4180 from ehsan/super35-video-only-final)

✅ Submodules that are properly updated:

Gym: ✅ PR branch is ahead of ehsan/super35-video-runtime-compat branch (fast-forward)

All submodule changes look good! ✨

@ehosseiniasl

Copy link
Copy Markdown
Contributor Author

This change has been split into four smaller stacked PRs for review:

  1. feat(vlm): support mixed SA-V and CapRL video manifests #4187 — mixed SA-V/CapRL data support
  2. fix(vlm): align training media with rollout placeholders #4188 — rollout/media alignment
  3. fix(video): load frozen vision weights and disable unused MTP #4189 — frozen-vision and MTP runtime compatibility
  4. [Superseded] Final SA-V + CapRL video GRPO stack #4180 — final recipe, launchers, and Gym pin

Please review and merge them in that order. The recomposed stack is byte-for-byte identical to the previous 20-commit #4180 head. The SA-V verifier remains separate in NVIDIA-NeMo/Gym#3504.

@ehosseiniasl

Copy link
Copy Markdown
Contributor Author

Superseded by the smaller four-PR review stack: #4187 → #4188 → #4189 → #4190. Please review and merge those PRs in order. This original unsplit PR is no longer part of the active review path.

@ehosseiniasl ehosseiniasl changed the title chore(video): add final SA-V + CapRL recipe and launchers [Superseded] Final SA-V + CapRL video GRPO stack Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant