Skip to content

fix(vlm): load frozen vision weights and disable unused MTP - #4315

Draft
ehosseiniasl wants to merge 1 commit into
ehsan/main-video-media-alignment-vllm029from
ehsan/main-video-frozen-vision-vllm029
Draft

ehosseiniasl wants to merge 1 commit into
ehsan/main-video-media-alignment-vllm029from
ehsan/main-video-frozen-vision-vllm029

Conversation

@ehosseiniasl

Copy link
Copy Markdown
Contributor

Summary

Preserves explicit vLLM load_format: auto when frozen vision weights are excluded from trainer-to-vLLM refit, and removes inherited repeated-layer/pattern state when mtp_num_layers: 0. This is PR 5 of the stacked current-main video/tracking port and contains one signed commit.

Series

The series is intentionally stacked so each review contains one focused commit. Merge or retarget in numeric order. The final cached-video source-timing fix is #4310, adapted from #4309.

Validation

  • signed-off commit
  • git diff --check
  • Python compile validation
  • focused unit/config tests and a vLLM 0.29 video RL smoke run are tracked at the stack tip

@copy-pr-bot

copy-pr-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ehosseiniasl
ehosseiniasl force-pushed the ehsan/main-video-media-alignment-vllm029 branch from d9095dc to c453c2b Compare October 1, 2026 00:43
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/main-video-frozen-vision-vllm029 branch from 5e7d39f to 640d554 Compare October 1, 2026 00:43
Signed-off-by: ehosseiniasl <ehsan.hosseiniasl@gmail.com>
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/main-video-media-alignment-vllm029 branch from c453c2b to 9d6ac0a Compare October 1, 2026 06:48
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/main-video-frozen-vision-vllm029 branch from 640d554 to 2eb476a Compare October 1, 2026 06:48
@terrykong terrykong added CI:L1 Run doctests, unit tests, and functional tests CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) and removed CI:L1 Run doctests, unit tests, and functional tests labels Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants