Skip to content

fix(vlm): materialize video frame contract in all runners - #4327

Draft
ehosseiniasl wants to merge 1 commit into
ehsan/main-video-cached-timing-vllm029from
ehsan/main-video-frame-contract-entrypoints-vllm029
Draft

ehosseiniasl wants to merge 1 commit into
ehsan/main-video-cached-timing-vllm029from
ehsan/main-video-frame-contract-entrypoints-vllm029

Conversation

@ehosseiniasl

Copy link
Copy Markdown
Contributor

Stacked on #4310.

Summary

  • call the existing video-config materializer from both the VLM and single-controller entrypoints before worker construction
  • propagate a 64-frame recipe into vLLM 0.29 media_io_kwargs.video.num_frames instead of its independent 32-frame default
  • add focused regression coverage for both entrypoints

Validation

  • 37 focused main/video/vLLM-0.29 tests passed in Slurm job 7535732
  • the live 16-node resolved config contains media_io_kwargs: {video: {num_frames: 64}}
  • BF16 policy/vLLM precision and the source 64-frame manifest remain unchanged

@copy-pr-bot

copy-pr-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ehosseiniasl
ehosseiniasl force-pushed the ehsan/main-video-frame-contract-entrypoints-vllm029 branch from 9fe29fa to a5a7623 Compare September 29, 2026 08:38
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/main-video-cached-timing-vllm029 branch from a83006a to 39381a4 Compare October 1, 2026 00:43
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/main-video-frame-contract-entrypoints-vllm029 branch from a5a7623 to 8dfeaf5 Compare October 1, 2026 00:43
Signed-off-by: ehosseiniasl <ehsan.hosseiniasl@gmail.com>
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/main-video-frame-contract-entrypoints-vllm029 branch from 8dfeaf5 to a0de8be Compare October 1, 2026 06:48
@ehosseiniasl
ehosseiniasl force-pushed the ehsan/main-video-cached-timing-vllm029 branch from 39381a4 to 0bd5bb0 Compare October 1, 2026 06:48
@terrykong terrykong added the CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) label Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants