Repository navigation
feat(dynamo): serve NeMo-Gym through the Dynamo frontend #4979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jthomson04
wants to merge
125
commits into
NVIDIA-NeMo:main
Choose a base branch
from
jthomson04:jthomson04/dynamo-gym
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9,164
−1,572
Open
Changes from all commits
Commits
Show all changes
125 commits
Select commit
Hold shift + click to select a range
27791a4
feat(dynamo)!: serve any vLLM generation config through Dynamo's back…
jthomson04 08c50d2
fix(dynamo): address the #4905 review
jthomson04 2ba2cae
style(dynamo): sort the test's chat_routed_experts import
jthomson04 b065eb6
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 94c0e96
build(gym): pin Gym#4817 rebased onto Gym main
jthomson04 e182811
fix(dynamo): apply the Gym Dynamo dialect per actor, after shard comp…
jthomson04 b498510
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 db52655
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 9223ffb
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 b3cd664
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 e0d3789
refactor(vllm): share the per-sample rollout pipeline and chat token …
jthomson04 89469ca
Merge jthomson04/vllm-request-pipeline into jthomson04/dynamo-native-…
jthomson04 d217dd8
refactor(dynamo): split NeMo-Gym support out to its own PR
jthomson04 3f45420
feat(dynamo): serve NeMo-Gym through the Dynamo frontend
jthomson04 3928525
refactor(vllm): serve every rollout through one worker method
jthomson04 1a2a581
Merge jthomson04/vllm-request-pipeline into jthomson04/dynamo-native-…
jthomson04 2cfb157
Merge jthomson04/dynamo-native-engine into jthomson04/dynamo-gym
jthomson04 29d2004
fix: adopt Gym's capture_key rename and config paths for the Gym bump
jthomson04 46317dc
fix(dynamo): address the #4979 review and slim the NeMo-Gym path
jthomson04 a15ba5d
build: pin Gym to Gym#4817's head a7be5c5 (dynamo_worker pairing chec…
jthomson04 ed3ee35
refactor(dynamo): serve only NeMo RL rollouts; general OpenAI path mo…
jthomson04 83cab88
fix(dynamo): address round-2 review (C26, C28-C31, C33, C34, C36, C37…
jthomson04 1e73994
refactor(dynamo): debloat the Dynamo serving path
jthomson04 4aedf28
Revert "refactor(dynamo): serve only NeMo RL rollouts; general OpenAI…
jthomson04 3c8fd6b
Merge #4905's rollout-only split into jthomson04/dynamo-gym
jthomson04 b5e19b1
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 8a4ccd9
Merge jthomson04/dynamo-native-engine into jthomson04/dynamo-gym
jthomson04 23f13fa
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 c60fc6d
Merge jthomson04/dynamo-native-engine into jthomson04/dynamo-gym
jthomson04 8ae17af
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 c2e4ef9
Merge upstream/main into jthomson04/vllm-request-pipeline
jthomson04 6a02b99
Merge jthomson04/vllm-request-pipeline (#4978) into jthomson04/dynamo…
jthomson04 cf5b5bc
Merge jthomson04/dynamo-native-engine into jthomson04/dynamo-gym
jthomson04 580fe70
fix(dynamo): reject score centering at startup
jthomson04 0521cfc
Merge upstream/main into jthomson04/vllm-request-pipeline
jthomson04 e798c86
refactor(vllm): address review nits
jthomson04 7945239
Merge jthomson04/vllm-request-pipeline (#4978) into jthomson04/dynamo…
jthomson04 627f317
Merge jthomson04/dynamo-native-engine (#4905) into jthomson04/dynamo-gym
jthomson04 d67311f
style(vllm): sort check_sampling_param import
jthomson04 ea0ecb7
Merge jthomson04/vllm-request-pipeline (#4978) into jthomson04/dynamo…
jthomson04 f58d36f
Merge jthomson04/dynamo-native-engine (#4905) into jthomson04/dynamo-gym
jthomson04 2583db9
style(dynamo): sort capture-test imports
jthomson04 d15b6f4
test(vllm): expect ValueError from the chat handler's sampling check
jthomson04 b0b6b32
Merge jthomson04/vllm-request-pipeline (#4978) into jthomson04/dynamo…
jthomson04 9f8492e
Merge jthomson04/dynamo-native-engine (#4905) into jthomson04/dynamo-gym
jthomson04 1fe249f
Merge upstream/main into jthomson04/vllm-request-pipeline
jthomson04 44671d3
Merge jthomson04/vllm-request-pipeline (#4978) into jthomson04/dynamo…
jthomson04 9721dd4
Merge jthomson04/dynamo-native-engine (#4905) into jthomson04/dynamo-gym
jthomson04 f28b4d6
fix(dynamo): stage native route tensors from Gym capture
jthomson04 0b7d378
test(data-plane): bind _parse_capture_admission on the route-tensor f…
jthomson04 c4fe2bd
fix(dynamo): accept enable_auto_tools=false when no tool parser is set
jthomson04 7688abe
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 4cfab93
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 ee813c3
fix(dynamo): address round-3 review
jthomson04 614fb0a
test(dynamo): cover the round-3 gaps; trim stale docstrings
jthomson04 f75aa87
feat(dynamo): pin every NeMo-Gym session to one engine
jthomson04 776aaa3
feat(dynamo): tokenize Gym chat with fastokens in the frontend when v…
jthomson04 a1659e9
revert: drop the frontend fastokens flag and the every-call session pin
jthomson04 f774780
refactor(dynamo): split the engine adapter into a shared Dynamo side …
jthomson04 096e872
docs(dynamo): scope the Dynamo guide to the SingleController
jthomson04 6f6de14
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 e506b68
Merge jthomson04/dynamo-native-engine (#4905) into jthomson04/dynamo-gym
jthomson04 3370812
refactor(dynamo): drop the endpoint_types setting; engines always ser…
jthomson04 790feb7
refactor(vllm): move the chat server out of the async worker
jthomson04 0b7894a
refactor(vllm): share the chat path's render, capture decision, turn …
jthomson04 43efaba
feat(dynamo)!: serve NeMo-Gym chat with NeMo RL's chat engine in Dyna…
jthomson04 817107f
build(gym): re-pin Gym to 4c84f173
jthomson04 a20b76d
test(dynamo): run every Gym overlay in fast CI; drop the swe1 recipe …
jthomson04 97e2a4b
docs(dynamo): review nits
jthomson04 9584986
fix(dynamo): acknowledge a refused capture call to Gym through the fr…
jthomson04 9331ee7
test(dynamo): add the step-order cases the review asked for
jthomson04 cca9af2
test(dynamo): drop the adapter test helper's unused prompt_logprobs
jthomson04 53a5298
fix(dynamo): answer a Gym call the engine refuses with the native status
jthomson04 6c56603
docs(dynamo): say what token_capture.generation_backend picks
jthomson04 62b375d
test(dynamo): fix the lint and Gym-dialect failures CI hit
jthomson04 fd91d76
fix(dynamo): fail engine errors and dead render workers as native does
jthomson04 3e81bca
fix(dynamo): render Gym calls as native does
jthomson04 f9172b4
fix(dynamo): reject at startup what the frontend would drop
jthomson04 53d7c9d
refactor(dynamo): one request contract, a typed plan, no dead code
jthomson04 28fd0e8
test(dynamo): tie the measure call to Gym; cover the budget fallback …
jthomson04 4fd57e8
docs(dynamo): correct the guide and comments
jthomson04 f7be6c1
test(dynamo): fake vLLM's chat request as a pydantic model in the wir…
jthomson04 45add8b
fix(dynamo): publish pydantic config blocks; keep the frontend host's…
jthomson04 c6a4c66
fix(dynamo): keep the generation worker's logging under Dynamo's Worker
jthomson04 5ff5507
Merge branch 'jthomson04/dynamo-native-engine' into jthomson04/dynamo…
jthomson04 aa4493e
test(dynamo): run Gym turn recovery behind Dynamo
jthomson04 59179cd
fix(dynamo): render calls without capture where NeMo-Gym is not insta…
jthomson04 4cbebb8
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 a2c74e6
fix(dynamo): fail Gym calls with non-finite log-probs with 500, as na…
jthomson04 a9ff06b
fix(dynamo): answer an engine's InvalidArgument with 500 on the Gym c…
jthomson04 9919396
Merge upstream/main into jthomson04/dynamo-native-engine
jthomson04 726f7d2
Merge branch 'jthomson04/dynamo-native-engine' into jthomson04/dynamo…
jthomson04 e47ce35
feat(dynamo): cut running NeMo-Gym calls at a checkpoint
jthomson04 5c7fa69
feat(dynamo): resume a cut NeMo-Gym call from its saved tokens
jthomson04 b6ae1cf
Merge the #4905 squash (f488a0c6eb) into jthomson04/dynamo-gym
jthomson04 4f2ee77
Merge upstream/main into jthomson04/dynamo-gym
jthomson04 4002952
refactor(gym): share the prompt and capture steps of a Gym chat call …
terrykong 7b536f5
fix(gym): run the shared chat-call steps under vLLM and Dynamo
jthomson04 f3d143b
refactor(gym): trim the shared chat-call steps
jthomson04 c810ee1
fix(vllm): answer vLLM errors raised while the request body is parsed
jthomson04 bbb35a2
test(gym): compare refused and failed calls on both paths
jthomson04 6877944
test(vllm): follow the shared chat-call checks in the native route tests
jthomson04 8415161
fix(gym): refuse stream: true on NeMo-Gym chat calls
jthomson04 7e29dcc
fix(gym): take reasoning_ended from the template render on both paths
jthomson04 4589ba2
fix(dynamo): give every engine the frontend's cut deadline
jthomson04 a6a13e7
docs(dynamo): the shared error map, refusals and the cut deadline
jthomson04 26d9d01
test: follow the shared chat-call steps outside the generation tests
jthomson04 56774f2
fix(dynamo): start the frontend's chat workers when the engines register
jthomson04 1cd7285
build(gym): bump the Gym submodule
zyzhou5 e1c510f
fix(dynamo): build the frontend's chat workers while the engines load
jthomson04 bb38b1d
Merge the Gym bump (#5195) and pin the rebased Dynamo dialect
jthomson04 34a41d8
build(gym): pin the Dynamo dialect with its review fixes
jthomson04 0d95075
fix(dynamo): reject request fields the frontend refuses or drops in s…
jthomson04 76111db
test(dynamo): run Gym prefix recovery behind Dynamo
jthomson04 766f81d
build(gym): pin Gym main, which has the Dynamo dialect
jthomson04 ffd880d
Merge main (e6d892c552: vLLM 0.33.0, docs reflow) into jthomson04/dyn…
jthomson04 011fe52
test(nightly): raise the GPU-hour cap to 5318 for the swe1 Dynamo nig…
jthomson04 4f97060
test(dynamo): give the render-pool test's parser the method vLLM 0.33…
jthomson04 e449a14
fix(gym): keep the native chat endpoint serving what it serves on main
jthomson04 7e4fbd5
Merge main (bb9ed784e4: multimodal prefix recovery) into jthomson04/d…
jthomson04 936f5d2
Merge main (705953be86: several HTTP frontends per engine, dynamic sa…
jthomson04 8904a7e
fix(dynamo): refuse several vLLM HTTP frontends behind Dynamo
jthomson04 027b75a
test(dynamo): run prefix recovery behind Dynamo in the fast set
jthomson04 4581367
Merge main (aa0f77af51: group length penalties, dynamic sampling for …
jthomson04 e3aec3d
Merge main (8f3595a112: Gym submodule bump with code_gen in OpenSandb…
jthomson04 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.