Repository navigation
feat: add DP memory controls and physical batch sizing #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1ede0be
feat: add DP memory training controls
binaryaaron c2dcc5a
fix: estimate preflight VRAM from quantization state
binaryaaron 57f33f2
feat: add physical batch size constraints
binaryaaron e55f688
fix: cover DP batching and progress edge cases
binaryaaron 9786362
test: improve batching and DP coverage
binaryaaron 595f805
feat: add training observability event and memory controls
binaryaaron a2caf72
fix: shut down NVML when sampler handle lookup fails
binaryaaron 98baeac
fix: harden DP observability review paths
binaryaaron 0be87a6
fix: avoid deprecated quantization and PRV APIs
binaryaaron cd89959
fix: address DP memory review comments
binaryaaron 5452f20
fix: address DP memory review follow-ups
binaryaaron 6e6737f
fix: clean up DP loss probe state
binaryaaron 3310e23
test(config): cover nested training memory inputs
binaryaaron 8d3f317
fix(preflight): use physical batch for VRAM check
binaryaaron 95fae4a
fix(training): preserve DP loss semantics
binaryaaron 0535fcb
test(training): cover ghost loss ignore masking
binaryaaron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why this isn't the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping
hooksas the default for now.ghostis the useful lower-memory opt-in path, but it depends on Opacus Fast/Ghost clipping support and model behavior like honoringlogits_to_keep;hooksis still the stable/widest-coverage path. The new parity tests give us a better basis to revisit the default after more e2e/GPU confidence.