Skip to content

Fix issue running all tests with latest release#32

Merged
roclark merged 1 commit into
mainfrom
fix-run-all
Feb 22, 2021
Merged

Fix issue running all tests with latest release#32
roclark merged 1 commit into
mainfrom
fix-run-all

Conversation

@roclark
Copy link
Copy Markdown
Member

@roclark roclark commented Feb 22, 2021

The latest release introduced an issue while attempting to run all tests where a stacktrace would be thrown attempting to handle a test that no longer exists.

Signed-Off-By: Robert Clark roclark@nvidia.com

The latest release introduced an issue while attempting to run all tests
where a stacktrace would be thrown attempting to handle a test that no
longer exists.

Signed-Off-By: Robert Clark <roclark@nvidia.com>
@roclark roclark added bug Something isn't working commands Additions, removals, and updates to the core Bobber commands labels Feb 22, 2021
@roclark roclark added this to the Release 6.1.1 milestone Feb 22, 2021
@roclark roclark requested review from fredvx and joehandzik February 22, 2021 14:19
@roclark roclark self-assigned this Feb 22, 2021
@joehandzik
Copy link
Copy Markdown
Contributor

This is weird, because that test was never part of "run-all" anyway. Guess a difference that showed up as the implementation translated.

@roclark
Copy link
Copy Markdown
Member Author

roclark commented Feb 22, 2021

I think it was more just a result of the layout of the test-selector if-else branch. The RUN_STG_FILL command was just before the run-all command in the branch and it would only be hit once that occurred. Thought I got rid of this during my previous commit, but apparently not.

@roclark roclark merged commit f91be0f into main Feb 22, 2021
@roclark roclark deleted the fix-run-all branch February 22, 2021 16:19
@roclark roclark mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working commands Additions, removals, and updates to the core Bobber commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants