Skip to content

Upgrade Imageinary version#59

Merged
roclark merged 1 commit into
mainfrom
update-imageinary
May 4, 2021
Merged

Upgrade Imageinary version#59
roclark merged 1 commit into
mainfrom
update-imageinary

Conversation

@roclark
Copy link
Copy Markdown
Member

@roclark roclark commented Mar 29, 2021

The latest version of Imageinary has a new CLI which isn't compatible with the way it is called in the DALI tests at present.

Closes #50

Signed-Off-By: Robert Clark roclark@nvidia.com

@roclark roclark added the enhancement New feature or request label Mar 29, 2021
@roclark roclark added this to the Release 6.2.0 milestone Mar 29, 2021
@roclark roclark requested review from fredvx and joehandzik March 29, 2021 20:14
@roclark roclark self-assigned this Mar 29, 2021
@roclark roclark marked this pull request as draft March 29, 2021 20:15
@roclark
Copy link
Copy Markdown
Member Author

roclark commented Mar 29, 2021

This is on hold until Imageinary is published with the next nvidia-pyindex update as this update will pull an incompatible version in the meantime.

@roclark roclark force-pushed the update-imageinary branch from 9dcfa85 to b034199 Compare March 29, 2021 20:17
@roclark
Copy link
Copy Markdown
Member Author

roclark commented May 3, 2021

Imageinary has been updated with nvidia-pyindex and this can now be moved forward.

@roclark roclark marked this pull request as ready for review May 3, 2021 18:49
The latest version of Imageinary has a new CLI which isn't compatible
with the way it is called in the DALI tests at present.

Signed-Off-By: Robert Clark <roclark@nvidia.com>
@roclark roclark force-pushed the update-imageinary branch from b034199 to 4e3f6fe Compare May 3, 2021 18:51
Copy link
Copy Markdown

@fredvx fredvx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roclark roclark merged commit 6f9a77c into main May 4, 2021
@roclark roclark deleted the update-imageinary branch May 4, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update nvidia-imageinary version

2 participants