Repository navigation
Conversation
Signed-off-by: Deepak Jain <deepujain@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit e2875a6 in the Show a line coverage summary of the most impacted files.
TypeScript / code-coverage/cliThe overall line coverage in commit e2875a6 in the Show a line coverage summary of the most impacted files.
Updated |
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
|
Ready for review at Proposes one exact assertion-budget exception for Slice 3 PR #12648 on its Slice 1 base. CI, the Advisor and CodeRabbit are green on this head, all commits are verified and no review threads are open. Not passed yet:
|
Outcome
Proposes one exact assertion-budget exception for Slice 3 PR #12648 on its Slice 1 base. The independent check can consume this entry only after a maintainer merges this dependency into
codex/native-nvidia-inference; this draft does not waive that check.Reason
PR #12648 carries its proposed exception, but the independent check reads trusted base policy. Candidate policy cannot approve its own seven-point live assertion increase. The user supplied recorded direction from Aaron Erickson: https://nvidia.slack.com/archives/C0B1FQ51FP0/p1791301358361059. This PR requests maintainer review of the exact transition and does not claim GitHub approval.
Related issues
Refs #12558. Dependency for #12648, stacked on #12562.
Changes
ci/e2e-assertion-growth-exceptions.json.fdc4a78b5588629e26b00778d1bc82d69101077b9e372f2b58670510184579c2to candidate budget275391e461bd7f9ae5f8c59a724d4063e3bf1236d3d59586b1a1a223fcabe381. Changed budget bytes invalidate the entry.Verification
421b8ee6eda991738a5c0732a72826b0b7c907b2and Slice 3cd9ebcda0539f72d13d9ea49e1f92431b1740a36.e2875a664a94e426bd797e545cfb301a41fb7aae; diff contains no secrets, API keys, or credentials. No live inference or E2E dispatch was performed.Review notes
Maintainer review and merge into the target branch are required before the independent trusted-base gate can use this entry. No CI failure is waived. AI-assisted preparation; the policy-only diff was reviewed within the implementation workflow, not independently approved.
Signed-off-by: Deepak Jain deepujain@gmail.com