Skip to content

ci(e2e): propose trusted Slice 3 assertion exception - #12714

Open
deepujain wants to merge 1 commit into
codex/native-nvidia-inferencefrom
codex/12648-trusted-assertion-policy
Open

deepujain wants to merge 1 commit into
codex/native-nvidia-inferencefrom
codex/12648-trusted-assertion-policy

Conversation

@deepujain

Copy link
Copy Markdown
Collaborator

Outcome

Proposes one exact assertion-budget exception for Slice 3 PR #12648 on its Slice 1 base. The independent check can consume this entry only after a maintainer merges this dependency into codex/native-nvidia-inference; this draft does not waive that check.

Reason

PR #12648 carries its proposed exception, but the independent check reads trusted base policy. Candidate policy cannot approve its own seven-point live assertion increase. The user supplied recorded direction from Aaron Erickson: https://nvidia.slack.com/archives/C0B1FQ51FP0/p1791301358361059. This PR requests maintainer review of the exact transition and does not claim GitHub approval.

Related issues

Refs #12558. Dependency for #12648, stacked on #12562.

Changes

Verification

  • Existing growth guardrail parser and workflow-boundary suites: 76 tests passed.
  • Existing growth guardrails suite: 7 tests passed.
  • Exact budget SHA-256 values independently recomputed from Slice 1 421b8ee6eda991738a5c0732a72826b0b7c907b2 and Slice 3 cd9ebcda0539f72d13d9ea49e1f92431b1740a36.
  • Normal commit and pre-push publication validation passed; GitHub verified commit e2875a664a94e426bd797e545cfb301a41fb7aae; diff contains no secrets, API keys, or credentials. No live inference or E2E dispatch was performed.

Review notes

Maintainer review and merge into the target branch are required before the independent trusted-base gate can use this entry. No CI failure is waived. AI-assisted preparation; the policy-only diff was reviewed within the implementation workflow, not independently approved.


Signed-off-by: Deepak Jain deepujain@gmail.com

Signed-off-by: Deepak Jain <deepujain@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/NemoClaw/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 5ec124f7-7c02-4ed4-b26f-efda61952ded

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit e2875a6 in the codex/12648-trusted-... branch is 97%. The line coverage in commit 63002cd in the codex/native-nvidia-... branch is 96%.

Show a line coverage summary of the most impacted files.
File codex/native-nvidia-... 63002cd codex/12648-trusted-... e2875a6 +/-
nemoclaw/src/onboard/config.ts 98% 96% -2%
nemoclaw/src/index.ts 94% 93% -1%
nemoclaw/src/bl...t-management.ts 100% 100% 0%
nemoclaw/src/co.../config-show.ts 100% 100% 0%
nemoclaw/src/commands/slash.ts 100% 100% 0%
nemoclaw/src/on...native-route.ts 0% 100% +100%

TypeScript / code-coverage/cli

The overall line coverage in commit e2875a6 in the codex/12648-trusted-... branch is 85%. The line coverage in commit 63002cd in the codex/native-nvidia-... branch is 84%.

Show a line coverage summary of the most impacted files.
File codex/native-nvidia-... 63002cd codex/12648-trusted-... e2875a6 +/-
src/lib/actions.../status-text.ts 84% 46% -38%
src/lib/state/sandbox.ts 92% 83% -9%
src/lib/onboard...al-inference.ts 84% 90% +6%
src/lib/policy/index.ts 71% 79% +8%
src/lib/state/p...l-retirement.ts 79% 92% +13%
src/lib/onboard.../application.ts 55% 72% +17%
src/lib/inferen...nvidia/index.ts 0% 83% +83%
src/lib/adapter...gnostics-cli.ts 0% 87% +87%
src/lib/onboard...ternal-image.ts 0% 94% +94%
src/lib/securit...ig-structure.ts 0% 98% +98%

Updated October 07, 2026 01:13 UTC

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit e2875a6. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

Request review only when Require no Advisor blockers is green.

All previous runs

@deepujain
deepujain marked this pull request as ready for review October 7, 2026 03:58
@deepujain
deepujain requested review from ericksoa and rsliter October 7, 2026 04:06
@deepujain

Copy link
Copy Markdown
Collaborator Author

Ready for review at e2875a6.

Proposes one exact assertion-budget exception for Slice 3 PR #12648 on its Slice 1 base.

CI, the Advisor and CodeRabbit are green on this head, all commits are verified and no review threads are open.

Not passed yet:

  • Runs on ready for review: Running.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant