Skip to content

[cuda.compute]: fix alignment not being set properly for gpu_struct types#6995

Merged
NaderAlAwar merged 1 commit intoNVIDIA:mainfrom
NaderAlAwar:cuda-compute-gpu-struct-alignment-fix
Dec 16, 2025
Merged

[cuda.compute]: fix alignment not being set properly for gpu_struct types#6995
NaderAlAwar merged 1 commit intoNVIDIA:mainfrom
NaderAlAwar:cuda-compute-gpu-struct-alignment-fix

Conversation

@NaderAlAwar
Copy link
Contributor

Description

Prior to this PR, the alignment for a gpu_struct like this

@gpu_struct
class pair:
    first: np.float32
    second: np.float32

is being passed as 1 to c.parallel when it is supposed to be 4. This PR fixes that.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@NaderAlAwar NaderAlAwar requested a review from shwina December 16, 2025 20:51
@NaderAlAwar NaderAlAwar requested a review from a team as a code owner December 16, 2025 20:51
@github-project-automation github-project-automation bot moved this to Todo in CCCL Dec 16, 2025
@NaderAlAwar NaderAlAwar enabled auto-merge (squash) December 16, 2025 20:51
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Dec 16, 2025
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A test would be nice to have. Perhaps no the correctness test, but a test than retrieves iterator and checks that alignment is as expected

@github-actions
Copy link
Contributor

🥳 CI Workflow Results

🟩 Finished in 1h 12m: Pass: 100%/48 | Total: 13h 11m | Max: 47m 23s

See results here.

@NaderAlAwar NaderAlAwar merged commit 89e1b75 into NVIDIA:main Dec 16, 2025
64 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants