Skip to content

Fix NVRTC error handling #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix NVRTC error handling #173

merged 1 commit into from
Oct 18, 2024

Conversation

leofang
Copy link
Member

@leofang leofang commented Oct 16, 2024 •
edited
Loading

Close #142.

  • We always pass the NVRTC handle to handle_return() except when creating/destroying the handle
  • We form the error message in 2 steps, and the first step does not need any NVRTC handle

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 16, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang self-assigned this Oct 16, 2024
@leofang leofang added bug Something isn't working P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Oct 16, 2024
@leofang leofang added this to the cuda.core beta 1 milestone Oct 16, 2024
@leofang leofang requested a review from vzhurba01 October 16, 2024 00:33
@leofang leofang marked this pull request as ready for review October 16, 2024 00:33
@leofang
Copy link
Member Author

leofang commented Oct 16, 2024

/ok to test

(curious what would happen...)

@leofang
Copy link
Member Author

leofang commented Oct 16, 2024

/ok to test

@leofang leofang merged commit a860436 into NVIDIA:main Oct 18, 2024
1 check failed
@leofang leofang deleted the fix_nvrtc branch October 18, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhurba01 vzhurba01 Awaiting requested review from vzhurba01

Assignees

@leofang leofang

Labels
bug Something isn't working cuda.core Everything related to the cuda.core module P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 1
Development

Successfully merging this pull request may close these issues.

Fix handle_return for NVRTC
1 participant
@leofang