Repository navigation
Conversation
Add a local composite action (.github/actions/download-artifact-retry) that wraps actions/download-artifact@v8.0.1 with a single retry. When the first download attempt fails (e.g. "other side closed" network flakes), the action waits 15 s and tries again; the job fails only if the second attempt also fails. Apply the composite action to the 18 artifact-download steps in the four test workflows: - test-wheel-linux.yml (7 steps) - test-wheel-windows.yml (7 steps) - test-sdist-linux.yml (2 steps) - test-sdist-windows.yml (2 steps) The "prior branch" download steps use gh and are unchanged. The remaining 16 steps in build-wheel.yml, build-docs.yml, and coverage.yml can adopt the action in a follow-up.
Contributor
📝 SummarySummary by CodeRabbit
WalkthroughA composite GitHub Action now retries failed artifact downloads once after a configurable delay. Linux and Windows source-distribution and wheel test workflows use the action in place of direct artifact-download steps. ChangesArtifact download retry
Suggested reviewers: Priority: ⬇️ Low Change: Bug fix Merge Risk: 🟡 Moderate · up to Nightly wheel tests that target an older commit can fail at the first artifact download because the new retry action does not exist at that commit. Resolve the action from the workflow commit before merging.
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
- Review profile: CHILL
- Plan: Enterprise
- Run ID:
484d389c-e5ff-469a-9e96-8fef91bdd900
📒 Files selected for processing (5)
.github/actions/download-artifact-retry/action.yml.github/workflows/test-sdist-linux.yml.github/workflows/test-sdist-windows.yml.github/workflows/test-wheel-linux.yml.github/workflows/test-wheel-windows.yml
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.
The nightly workflow checks out an older wheel commit (inputs.sha), so a local ./.github/actions reference would not resolve until a main build contains the new action. Keep the wheel test workflows on actions/download-artifact for now; a follow-up PR will point them at the action by commit SHA.
Contributor
Author
|
/ok to test 8deb152 |
jpascucci-nv
approved these changes
Oct 6, 2026
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first of two PRs. It adds a local composite action (
.github/actions/download-artifact-retry) that wraps the pinnedactions/download-artifact@v8.0.1with a single retry. When the first download attempt fails due to a transient infrastructure error (e.g. "Unable to download artifact(s): other side closed", as seen in run 37529061189 job 112495868687 on the linux-aarch64 3.14t lane), the action waits 15 s and tries again. The job fails only if the second attempt also fails.In this PR the action is adopted by the 4 artifact-download steps in the sdist test workflows:
test-sdist-linux.yml(2 steps)test-sdist-windows.yml(2 steps)The sdist jobs check out the workflow commit, so a local
./.github/actions/...reference resolves correctly.Follow-up PR
The 14 download steps in
test-wheel-linux.ymlandtest-wheel-windows.ymlare intentionally left unchanged here. The nightly workflow passesinputs.sha(the head of the last successful mainCIrun), and the wheel jobs check out that commit, which can predate the new action. A local./reference would therefore fail with a missingaction.ymluntil a main build contains the action. Once this PR is merged, a second PR will point the wheel steps atNVIDIA/cuda-python/.github/actions/download-artifact-retry@<merged-sha>, which GitHub fetches directly from that commit.The "prior branch" download steps that use
gh run downloadare unchanged. The remaining steps inbuild-wheel.yml,build-docs.yml, andcoverage.ymlcan adopt the action later.Checklist