-
Notifications
You must be signed in to change notification settings - Fork 176
Enable Cython tests for cuda.bindings
#323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
11a9063
enable Cython tests for cuda.bindings
leofang 636bd19
build Cython test modules
leofang d208f3e
Update gh-build-and-test.yml
leofang e0c729c
Install system gcc
leofang 2fbac68
No sudo
leofang 371b318
also set CUDA_HOME
leofang 7c5f9b9
Try to find Python include
leofang 4e05ef2
nit: add a skip condition and comments
leofang 0a9cb7d
Merge branch 'main' into enable_cython_test
leofang 252a930
Merge branch 'main' into enable_cython_test
leofang a7f46ca
simplify
leofang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -272,6 +272,9 @@ jobs: | |
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
env: | ||
# we use self-hosted runners on which setup-python behaves weirdly... | ||
AGENT_TOOLSDIRECTORY: "/opt/hostedtoolcache" | ||
|
||
- name: Set up mini CTK | ||
uses: ./.github/actions/fetch_ctk | ||
|
@@ -280,6 +283,13 @@ jobs: | |
host-platform: ${{ matrix.host-platform }} | ||
cuda-version: ${{ matrix.cuda-version }} | ||
|
||
- name: Install dependencies | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TBH I don't want to install any build tools in the test pipeline, but it seems to be the easiest path... |
||
if: ${{ env.SKIP_CUDA_BINDINGS_TEST == '0' }} | ||
shell: bash --noprofile --norc -xeuo pipefail {0} | ||
run: | | ||
# cython tests require gcc | ||
apt install -y build-essential | ||
|
||
- name: Run cuda.bindings tests | ||
if: ${{ env.SKIP_CUDA_BINDINGS_TEST == '0' }} | ||
shell: bash --noprofile --norc -xeuo pipefail {0} | ||
|
@@ -293,8 +303,13 @@ jobs: | |
pushd ./cuda_bindings | ||
pip install -r requirements.txt | ||
pytest -rxXs tests/ | ||
# TODO: enable cython tests | ||
#pytest tests/cython | ||
if [[ "${{ matrix.host-platform }}" == linux* ]]; then | ||
bash tests/cython/build_tests.sh | ||
elif [[ "${{ matrix.host-platform }}" == win* ]]; then | ||
# TODO: enable this once win-64 runners are up | ||
exit 1 | ||
fi | ||
pytest -rxXs tests/cython | ||
popd | ||
|
||
- name: Run cuda.core tests | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xref: